-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-45742][CORE][CONNECT][MLLIB][PYTHON] Introduce an implicit function for Scala Array to wrap into immutable.ArraySeq
.
#43607
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.util | ||
|
||
import scala.collection.immutable | ||
|
||
/** | ||
* Implicit methods related to Scala Array. | ||
*/ | ||
private[spark] object ArrayImplicits { | ||
|
||
implicit class SparkArrayOps[T](xs: Array[T]) { | ||
|
||
/** | ||
* Wraps an Array[T] as an immutable.ArraySeq[T] without copying. | ||
*/ | ||
def toImmutableArraySeq: immutable.ArraySeq[T] = | ||
if (xs eq null) null | ||
else immutable.ArraySeq.unsafeWrapArray(xs) | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.util | ||
|
||
import scala.collection.immutable | ||
|
||
import org.apache.spark.SparkFunSuite | ||
import org.apache.spark.util.ArrayImplicits._ | ||
|
||
class ArrayImplicitsSuite extends SparkFunSuite { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Although this pr has modified the The issue with the utils module test will be followed up separately. |
||
|
||
test("Int Array") { | ||
val data = Array(1, 2, 3) | ||
val arraySeq = data.toImmutableArraySeq | ||
assert(arraySeq.getClass === classOf[immutable.ArraySeq.ofInt]) | ||
assert(arraySeq.length === 3) | ||
assert(arraySeq.unsafeArray.sameElements(data)) | ||
} | ||
|
||
test("TestClass Array") { | ||
val data = Array(TestClass(1), TestClass(2), TestClass(3)) | ||
val arraySeq = data.toImmutableArraySeq | ||
assert(arraySeq.getClass === classOf[immutable.ArraySeq.ofRef[TestClass]]) | ||
assert(arraySeq.length === 3) | ||
assert(arraySeq.unsafeArray.sameElements(data)) | ||
} | ||
|
||
test("Null Array") { | ||
val data: Array[Int] = null | ||
val arraySeq = data.toImmutableArraySeq | ||
assert(arraySeq == null) | ||
} | ||
|
||
case class TestClass(i: Int) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.