[SPARK-47443][SQL] Window Aggregate support for collations #45568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
reviewed
Mar 20, 2024
| val t1 = "T_NON_BINARY" | ||
| val t2 = "T_BINARY" | ||
|
|
||
| withTable(t1) { |
There was a problem hiding this comment.
You can list multiple tables:
Suggested change
| withTable(t1) { | |
| withTable(t1, t2) { |
MaxGekk
approved these changes
Mar 20, 2024
|
+1, LGTM. Merging to master. |
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? This PR introduces support for Window Aggregates when partitioning is done against expressions with non-binary collation. The approach is same as for regular aggregates. Instead of doing byte-for-byte comparison against `UnsafeRow` we fall back to interpreted mode if there is a data type in grouping expressions that doesn't satisfy `isBinaryStable` constraint. ### Why are the changes needed? Previous implementation returned invalid results. ### Does this PR introduce _any_ user-facing change? yes - fixes incorrect behavior. ### How was this patch tested? New test is added in `CollationSuite`. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45568 from dbatomic/win_agg_support_for_collations. Authored-by: Aleksandar Tomic <aleksandar.tomic@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces support for Window Aggregates when partitioning is done against expressions with non-binary collation.
The approach is same as for regular aggregates. Instead of doing byte-for-byte comparison against
UnsafeRowwe fall back to interpreted mode if there is a data type in grouping expressions that doesn't satisfyisBinaryStableconstraint.Why are the changes needed?
Previous implementation returned invalid results.
Does this PR introduce any user-facing change?
yes - fixes incorrect behavior.
How was this patch tested?
New test is added in
CollationSuite.Was this patch authored or co-authored using generative AI tooling?
No.