Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-47455][BUILD] Fix resource leak during the initialization of scalaStyleOnCompileConfig in SparkBuild.scala #45582

Closed
wants to merge 2 commits into from
+14 −9
Closed

[SPARK-47455][BUILD] Fix resource leak during the initialization of scalaStyleOnCompileConfig in SparkBuild.scala #45582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b456c32
init
LuciferYang Mar 19, 2024
8038df2
fix
LuciferYang Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions project/SparkBuild.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,16 +160,21 @@ object SparkBuild extends PomBuild {
val replacements = Map(
"""customId="println" level="error"""" -> """customId="println" level="warn""""
)
var contents = Source.fromFile(in).getLines.mkString("\n")
for ((k, v) <- replacements) {
require(contents.contains(k), s"Could not rewrite '$k' in original scalastyle config.")
contents = contents.replace(k, v)
}
new PrintWriter(out) {
write(contents)
close()
val source = Source.fromFile(in)
try {
var contents = source.getLines.mkString("\n")
for ((k, v) <- replacements) {
require(contents.contains(k), s"Could not rewrite '$k' in original scalastyle config.")
contents = contents.replace(k, v)
}
new PrintWriter(out) {
write(contents)
close()
}
out
} finally {
source.close()
}
out
}

// Return a cached scalastyle task for a given configuration (usually Compile or Test)
Expand Down