[SPARK-47501][SQL] Add convertDateToDate like the existing convertTimestampToTimestamp for JdbcDialect #45638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estampToTimestamp for JdbcDialect
yaooqinn
commented
Mar 21, 2024
| @@ -307,24 +307,23 @@ private object PostgresDialect extends JdbcDialect with SQLConfHelper { | |||
| override def convertJavaTimestampToTimestamp(t: Timestamp): Timestamp = { | |||
| // Variable names come from PostgreSQL "constant field docs": | |||
| // https://jdbc.postgresql.org/documentation/publicapi/index.html?constant-values.html | |||
| val POSTGRESQL_DATE_NEGATIVE_INFINITY = -9223372036832400000L | |||
| val POSTGRESQL_DATE_NEGATIVE_SMALLER_INFINITY = -185543533774800000L | |||
There was a problem hiding this comment.
*_SMALLER_INFINITYs are for PgResultSet to identify date infinities internally, they are supplanted with the larger abs-values to clients
|
cc @cloud-fan @dongjoon-hyun @mingkangli-db, thanks |
|
Thank you @dongjoon-hyun |
cloud-fan
reviewed
Mar 21, 2024
| * @return the date value after conversion | ||
| */ | ||
| @Since("4.0.0") | ||
| def convertDateToDate(d: Date): Date = d |
There was a problem hiding this comment.
for name consistency, should this be convertJavaDateToDate?
There was a problem hiding this comment.
Oh, thanks. +1 for the above new name.
There was a problem hiding this comment.
Thank you for being so careful. And sorry for my carelessness
There was a problem hiding this comment.
To fix my mistake, I sent #45656. Please help review when you have some time
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
…estampToTimestamp for JdbcDialect ### What changes were proposed in this pull request? Add convertDateToDate like the existing convertTimestampToTimestamp for JdbcDialect ### Why are the changes needed? The date '±infinity' values cause overflows like timestamp '±infinity' in apache#41843 ### Does this PR introduce _any_ user-facing change? fix expected overflow for dates to align with the timestamps of PostgreSQL ### How was this patch tested? new tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#45638 from yaooqinn/SPARK-47501. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add convertDateToDate like the existing convertTimestampToTimestamp for JdbcDialect
Why are the changes needed?
The date '±infinity' values cause overflows like timestamp '±infinity' in #41843
Does this PR introduce any user-facing change?
fix expected overflow for dates to align with the timestamps of PostgreSQL
How was this patch tested?
new testsWas this patch authored or co-authored using generative AI tooling?
no