[DRAFT][SQL] Hash aggregate support for strings with collation #45929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Apr 8, 2024
| @@ -168,7 +168,13 @@ object ExprUtils extends QueryErrorsBase { | |||
| a.failAnalysis( | |||
| errorClass = "MISSING_GROUP_BY", | |||
| messageParameters = Map.empty) | |||
| case e: Attribute if !a.groupingExpressions.exists(_.semanticEquals(e)) => | |||
| case e: Attribute if !a.groupingExpressions.exists(_.semanticEquals(e)) && | |||
| !a.groupingExpressions.exists { | |||
There was a problem hiding this comment.
why do we need this change?
There was a problem hiding this comment.
without it, it hits the QueryCompilationErrors.columnNotInGroupByClauseError(e)
with error: Job aborted due to stage failure: Task 0 in stage 2.0 failed 1 times, most recent failure: Lost task 0.0 in stage 2.0 (TID 2) (192.168.15.30 executor driver): org.apache.spark.SparkException: [INTERNAL_ERROR] Couldn't find name#17 in [collationkey(name#17)#30,count(1)#19L] SQLSTATE: XX000
with query plan:
Aggregate [collationkey(name#17)], [any_value(name#17, false) AS name#24, count(1) AS count(1)#20L]
+- LogicalRDD [name#17], false
so name#17 is not found in groupingExpressions
uros-db
changed the title
uros-db
changed the title
uros-db
changed the title
uros-db
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable collation support for hash aggregate.
Why are the changes needed?
Improve AGGREGATE performance for collated strings, arrays of strings, and structs with strings.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
E2e SQL tests in CollationSuite, existing TPCDS collation query test suite.
Was this patch authored or co-authored using generative AI tooling?
Yes.