[SPARK-48556][SQL] Fix incorrect error message pointing to UNSUPPORTED_GROUPING_EXPRESSION #46900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolamand-db
changed the title
cloud-fan
reviewed
Jun 7, 2024
| @@ -267,6 +267,7 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB | |||
| // Early checks for column definitions, to produce better error messages | |||
| ColumnDefinition.checkColumnDefinitions(operator) | |||
|
|
|||
| var checkLowPriorityErrors = () => () | |||
There was a problem hiding this comment.
how about
var stagedError: Option[() => Unit] = None
...
if (stagedError.isEmpty) stagedError = ...
...
if (stagedError.isDefined) stagedError.get.apply()
cloud-fan
approved these changes
Jun 11, 2024
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Following sequence of queries produces
UNSUPPORTED_GROUPING_EXPRESSIONerror:However, the appropriate error should point the user to the invalid
dummycolumn name.Fix the problem by deprioritizing
GroupingandGroupingIDnodes in plan which were not resolved and thus cause the unwanted error.Why are the changes needed?
To fix the described issue.
Does this PR introduce any user-facing change?
Yes, it displays proper error message to user instead of misleading one.
How was this patch tested?
Added test to
QueryCompilationErrorsSuite.Was this patch authored or co-authored using generative AI tooling?
No.