Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48559][SQL] Fetch globalTempDatabase name directly without invoking initialization of GlobalaTempViewManager #46907

Closed
wants to merge 1 commit into from

Conversation

willwwt
Copy link
Contributor

@willwwt willwwt commented Jun 6, 2024

What changes were proposed in this pull request?

It's not necessary to create GlobalaTempViewManager only for getting the global temp db name. This PR updates the code to avoid this, as global temp db name is just a config.

Why are the changes needed?

avoid unnecessary RPC calls to check existence of global temp db

Does this PR introduce any user-facing change?

no

How was this patch tested?

existing tests

Was this patch authored or co-authored using generative AI tooling?

no

@willwwt willwwt changed the title Fetch globalTempDatabase name directly without invoking initializatio… Fetch globalTempDatabase name directly without invoking initialization of GlobalaTempViewManager Jun 6, 2024
@github-actions github-actions bot added the SQL label Jun 6, 2024
@cloud-fan cloud-fan changed the title Fetch globalTempDatabase name directly without invoking initialization of GlobalaTempViewManager [SPARK-48559][SQL] Fetch globalTempDatabase name directly without invoking initialization of GlobalaTempViewManager Jun 7, 2024
@cloud-fan
Copy link
Contributor

the docker test failure is unrelated and the offending commit is already reverted. I'm merging it to master, thanks!

@cloud-fan cloud-fan closed this in d81b1e3 Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants