[SPARK-48604][SQL] Replace deprecated new ArrowType.Decimal(precision, scale) method call
#46961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @LuciferYang |
LuciferYang
reviewed
Jun 13, 2024
| @@ -51,7 +51,7 @@ private[sql] object ArrowUtils { | |||
| case BinaryType if !largeVarTypes => ArrowType.Binary.INSTANCE | |||
| case _: StringType if largeVarTypes => ArrowType.LargeUtf8.INSTANCE | |||
| case BinaryType if largeVarTypes => ArrowType.LargeBinary.INSTANCE | |||
| case DecimalType.Fixed(precision, scale) => new ArrowType.Decimal(precision, scale) | |||
| case DecimalType.Fixed(precision, scale) => new ArrowType.Decimal(precision, scale, 8 * 16) | |||
There was a problem hiding this comment.
Can we use a named val to replace this magic number?
There was a problem hiding this comment.
I refer to the style of lines 44-47
|
Only one case? |
Yes, I made a check. |
|
+1, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr replaces deprecated classes and methods of
arrow-vectorcalled in Spark:Decimal(int precision, int scale)->Decimal( @JsonProperty("precision") int precision, @JsonProperty("scale") int scale, @JsonProperty("bitWidth") int bitWidth )All
arrow-vectorrelated Spark classes, I made a double check, only inArrowUtilsthere is a deprecated method call.Why are the changes needed?
Clean up deprecated API usage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Passed GA.
Was this patch authored or co-authored using generative AI tooling?
No.