[SPARK-48342][FOLLOWUP][SQL] Remove unnecessary import in AstBuilder #47025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidm-db
changed the title
davidm-db
changed the title
cloud-fan
approved these changes
Jun 19, 2024
davidm-db
changed the title
davidm-db
force-pushed
the
sql_scripting_remove_import
branch
from
8e2334e
to
5b9acf5
Compare
HyukjinKwon
approved these changes
Jun 20, 2024
|
Merged to master |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? In [SQL Scripting parser PR](apache#46665) we didn't notice that import for `scala.collection.immutable.Seq` was added to `AstBuilder` (probably accidentally by IntelliJ). While this import is not unused per se, it is logically not needed (since Scala 2.13, `scala.Seq` is an alias for `scala.collection.immutable.Seq`). Anyways, no enforcement was there before and it makes sense to leave it as such. It's not in any way required for SQL Scripting parser change. ### Why are the changes needed? To remove accidentally added package enforcement that's not needed and wasn't used before. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Already existing tests cover this change. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47025 from davidm-db/sql_scripting_remove_import. Authored-by: David Milicevic <david.milicevic@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In SQL Scripting parser PR we didn't notice that import for
scala.collection.immutable.Seqwas added toAstBuilder(probably accidentally by IntelliJ). While this import is not unused per se, it is logically not needed (since Scala 2.13,scala.Seqis an alias forscala.collection.immutable.Seq).Anyways, no enforcement was there before and it makes sense to leave it as such. It's not in any way required for SQL Scripting parser change.
Why are the changes needed?
To remove accidentally added package enforcement that's not needed and wasn't used before.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Already existing tests cover this change.
Was this patch authored or co-authored using generative AI tooling?
No.