Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48716] Add jobGroupId to SparkListenerSQLExecutionStart #47092

Closed
wants to merge 2 commits into from

Conversation

gjxdxh
Copy link
Contributor

@gjxdxh gjxdxh commented Jun 25, 2024

What changes were proposed in this pull request?

Add jobGroupId to SparkListenerSQLExecutionStart

Why are the changes needed?

JobGroupId can be used to combine jobs within the same group. This is going to be useful in the listener so it makes the job grouping easy to do

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit Test

Was this patch authored or co-authored using generative AI tooling?

No

@gjxdxh
Copy link
Contributor Author

gjxdxh commented Jun 26, 2024

@JoshRosen Can you help review this PR?

Copy link
Contributor

@JoshRosen JoshRosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful change and looks good to me pending the resolution of review comments.

@gjxdxh gjxdxh requested a review from JoshRosen July 8, 2024 18:40
Copy link
Contributor

@JoshRosen JoshRosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so I am going to merge this to master. Thank you!

@JoshRosen JoshRosen closed this in 4c99c4d Jul 9, 2024
ericm-db pushed a commit to ericm-db/spark that referenced this pull request Jul 10, 2024
### What changes were proposed in this pull request?
Add jobGroupId to SparkListenerSQLExecutionStart

### Why are the changes needed?
JobGroupId can be used to combine jobs within the same group. This is going to be useful in the listener so it makes the job grouping easy to do

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Unit Test

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#47092 from gjxdxh/gjxdxh/SPARK-48716.

Authored-by: Lingkai Kong <lingkai.kong@databricks.com>
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
biruktesf-db pushed a commit to biruktesf-db/spark that referenced this pull request Jul 11, 2024
### What changes were proposed in this pull request?
Add jobGroupId to SparkListenerSQLExecutionStart

### Why are the changes needed?
JobGroupId can be used to combine jobs within the same group. This is going to be useful in the listener so it makes the job grouping easy to do

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Unit Test

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#47092 from gjxdxh/gjxdxh/SPARK-48716.

Authored-by: Lingkai Kong <lingkai.kong@databricks.com>
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
jingz-db pushed a commit to jingz-db/spark that referenced this pull request Jul 22, 2024
### What changes were proposed in this pull request?
Add jobGroupId to SparkListenerSQLExecutionStart

### Why are the changes needed?
JobGroupId can be used to combine jobs within the same group. This is going to be useful in the listener so it makes the job grouping easy to do

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Unit Test

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#47092 from gjxdxh/gjxdxh/SPARK-48716.

Authored-by: Lingkai Kong <lingkai.kong@databricks.com>
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
### What changes were proposed in this pull request?
Add jobGroupId to SparkListenerSQLExecutionStart

### Why are the changes needed?
JobGroupId can be used to combine jobs within the same group. This is going to be useful in the listener so it makes the job grouping easy to do

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Unit Test

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#47092 from gjxdxh/gjxdxh/SPARK-48716.

Authored-by: Lingkai Kong <lingkai.kong@databricks.com>
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants