-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-48716] Add jobGroupId to SparkListenerSQLExecutionStart #47092
Conversation
@JoshRosen Can you help review this PR? |
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a useful change and looks good to me pending the resolution of review comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, so I am going to merge this to master. Thank you!
### What changes were proposed in this pull request? Add jobGroupId to SparkListenerSQLExecutionStart ### Why are the changes needed? JobGroupId can be used to combine jobs within the same group. This is going to be useful in the listener so it makes the job grouping easy to do ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit Test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47092 from gjxdxh/gjxdxh/SPARK-48716. Authored-by: Lingkai Kong <lingkai.kong@databricks.com> Signed-off-by: Josh Rosen <joshrosen@databricks.com>
### What changes were proposed in this pull request? Add jobGroupId to SparkListenerSQLExecutionStart ### Why are the changes needed? JobGroupId can be used to combine jobs within the same group. This is going to be useful in the listener so it makes the job grouping easy to do ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit Test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47092 from gjxdxh/gjxdxh/SPARK-48716. Authored-by: Lingkai Kong <lingkai.kong@databricks.com> Signed-off-by: Josh Rosen <joshrosen@databricks.com>
### What changes were proposed in this pull request? Add jobGroupId to SparkListenerSQLExecutionStart ### Why are the changes needed? JobGroupId can be used to combine jobs within the same group. This is going to be useful in the listener so it makes the job grouping easy to do ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit Test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47092 from gjxdxh/gjxdxh/SPARK-48716. Authored-by: Lingkai Kong <lingkai.kong@databricks.com> Signed-off-by: Josh Rosen <joshrosen@databricks.com>
### What changes were proposed in this pull request? Add jobGroupId to SparkListenerSQLExecutionStart ### Why are the changes needed? JobGroupId can be used to combine jobs within the same group. This is going to be useful in the listener so it makes the job grouping easy to do ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit Test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47092 from gjxdxh/gjxdxh/SPARK-48716. Authored-by: Lingkai Kong <lingkai.kong@databricks.com> Signed-off-by: Josh Rosen <joshrosen@databricks.com>
What changes were proposed in this pull request?
Add jobGroupId to SparkListenerSQLExecutionStart
Why are the changes needed?
JobGroupId can be used to combine jobs within the same group. This is going to be useful in the listener so it makes the job grouping easy to do
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit Test
Was this patch authored or co-authored using generative AI tooling?
No