[SPARK-48747][SQL] Add code point iterator to UTF8String #47123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @uros-db could you please create a JIRA ticket for this change?
|
@allisonwang-db will do, thanks for the heads up |
uros-db
changed the title
cloud-fan
reviewed
Jun 28, 2024
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Jun 28, 2024
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Jun 28, 2024
cloud-fan
approved these changes
Jun 28, 2024
|
@cloud-fan ready to merge |
|
thanks, merging to master! |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? Add code point iteration capabilities to the UTF8String class. ### Why are the changes needed? Need these changes to enable collation support for some expressions. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Testing new UTF8String features in `UTF8StringSuite`. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47123 from uros-db/utf8-iterator. Authored-by: Uros Bojanic <157381213+uros-db@users.noreply.github.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add code point iteration capabilities to the UTF8String class.
Why are the changes needed?
Need these changes to enable collation support for some expressions.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Testing new UTF8String features in
UTF8StringSuite.Was this patch authored or co-authored using generative AI tooling?
No.