[SPARK-44718][FOLLOWUP][DOCS] Avoid using ConfigEntry in spark.sql.columnVector.offheap.enabled's doc field #47165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ector.offheap.enabled's doc field
|
@cloud-fan @mojodna @HyukjinKwon thanks |
yaooqinn
changed the title
allisonwang-db
approved these changes
Jul 1, 2024
dongjoon-hyun
approved these changes
Jul 1, 2024
HyukjinKwon
approved these changes
Jul 2, 2024
|
Merged to master, thank you @allisonwang-db @dongjoon-hyun @HyukjinKwon |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…lumnVector.offheap.enabled's doc field ### What changes were proposed in this pull request? Followup of apache#42394 ``` * - spark.sql.columnVector.offheap.enabled - When true, use OffHeapColumnVector in ColumnarBatch. Defaults to ConfigEntry(key=spark.memory.offHeap.enabled, defaultValue=false, doc=If true, Spark will attempt to use off-heap memory for certain operations. If off-heap memory use is enabled, then spark.memory.offHeap.size must be positive., public=true, version=1.6.0). - <value of spark.memory.offHeap.enabled> - 2.3.0 ``` The doc field shall be interpolated by MEMORY_OFFHEAP_ENABLED.key instead of MEMORY_OFFHEAP_ENABLED. In this PR, we remove the doc redundant doc as it's also can be found in the `MEMORY_OFFHEAP_ENABLED.defaultValueString` ### Why are the changes needed? docfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? manually debugging ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47165 from yaooqinn/minor2. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Followup of #42394
The doc field shall be interpolated by MEMORY_OFFHEAP_ENABLED.key instead of MEMORY_OFFHEAP_ENABLED. In this PR, we remove the doc redundant doc as it's also can be found in the
MEMORY_OFFHEAP_ENABLED.defaultValueStringWhy are the changes needed?
docfix
Does this PR introduce any user-facing change?
no
How was this patch tested?
manually debugging
Was this patch authored or co-authored using generative AI tooling?
no