[SPARK-48307][SQL][FOLLOWUP] Eliminate the use of mutable.ArrayBuffer #47185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-young-db
approved these changes
Jul 2, 2024
HyukjinKwon
approved these changes
Jul 3, 2024
cloud-fan
reviewed
Jul 3, 2024
| @@ -140,26 +140,31 @@ case class InlineCTE( | |||
| cteMap: mutable.Map[Long, CTEReferenceInfo]): LogicalPlan = { | |||
| plan match { | |||
| case WithCTE(child, cteDefs) => | |||
| val notInlined = mutable.ArrayBuffer.empty[CTERelationDef] | |||
| cteDefs.foreach { cteDef => | |||
| val notInlined = cteDefs.map {cteDef => | |||
There was a problem hiding this comment.
why can't call flatMap directly here?
There was a problem hiding this comment.
Good point :) I was confused myself somewhat.
yaooqinn
reviewed
Jul 3, 2024
| @@ -140,26 +140,31 @@ case class InlineCTE( | |||
| cteMap: mutable.Map[Long, CTEReferenceInfo]): LogicalPlan = { | |||
| plan match { | |||
| case WithCTE(child, cteDefs) => | |||
| val notInlined = mutable.ArrayBuffer.empty[CTERelationDef] | |||
| cteDefs.foreach { cteDef => | |||
| val notInlined = cteDefs.map {cteDef => | |||
There was a problem hiding this comment.
nit: squash cteDefs.map -> Option + flatMap -> Seq to cteDefs.flatMap -> Seq
yaooqinn
reviewed
Jul 3, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InlineCTE.scala
Outdated
Show resolved
Hide resolved
…mizer/InlineCTE.scala
yaooqinn
reviewed
Jul 3, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InlineCTE.scala
Outdated
Show resolved
Hide resolved
…mizer/InlineCTE.scala
|
thanks, merging to master! |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Jul 10, 2024
### What changes were proposed in this pull request? We can eliminate the use of mutable.ArrayBuffer by using `flatmap`. ### Why are the changes needed? Code simplification and optimization. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UT ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47185 from amaliujia/followup_cte. Lead-authored-by: Rui Wang <rui.wang@databricks.com> Co-authored-by: Kent Yao <yao@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
jingz-db
pushed a commit
to jingz-db/spark
that referenced
this pull request
Jul 22, 2024
### What changes were proposed in this pull request? We can eliminate the use of mutable.ArrayBuffer by using `flatmap`. ### Why are the changes needed? Code simplification and optimization. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UT ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47185 from amaliujia/followup_cte. Lead-authored-by: Rui Wang <rui.wang@databricks.com> Co-authored-by: Kent Yao <yao@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? We can eliminate the use of mutable.ArrayBuffer by using `flatmap`. ### Why are the changes needed? Code simplification and optimization. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UT ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47185 from amaliujia/followup_cte. Lead-authored-by: Rui Wang <rui.wang@databricks.com> Co-authored-by: Kent Yao <yao@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We can eliminate the use of mutable.ArrayBuffer by using
flatmap.Why are the changes needed?
Code simplification and optimization.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT
Was this patch authored or co-authored using generative AI tooling?
No