[SPARK-48806][SQL] Pass actual exception when url_decode fails #47211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @zzzzming95 @MaxGekk Could you please take a look? |
yaooqinn
reviewed
Jul 4, 2024
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala
Outdated
Show resolved
Hide resolved
yaooqinn
approved these changes
Jul 4, 2024
yaooqinn
added a commit
that referenced
this pull request
Jul 4, 2024
### What changes were proposed in this pull request? Pass actual exception for url_decode. Follow-up to https://issues.apache.org/jira/browse/SPARK-40156 ### Why are the changes needed? Currently url_decode function ignores actual exception, which contains information that is useful for quickly locating the problem. Like executing this sql: ``` select url_decode('https%3A%2F%2spark.apache.org'); ``` We only get the error message: ``` org.apache.spark.SparkIllegalArgumentException: [CANNOT_DECODE_URL] The provided URL cannot be decoded: https%3A%2F%2spark.apache.org. Please ensure that the URL is properly formatted and try again. at org.apache.spark.sql.errors.QueryExecutionErrors$.illegalUrlError(QueryExecutionErrors.scala:376) at org.apache.spark.sql.catalyst.expressions.UrlCodec$.decode(urlExpressions.scala:118) at org.apache.spark.sql.catalyst.expressions.UrlCodec.decode(urlExpressions.scala) ``` However, the actual useful exception information is ignored: ``` java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - Error at index 1 in: "2s" ``` After this pr we will get: ``` org.apache.spark.SparkIllegalArgumentException: [CANNOT_DECODE_URL] The provided URL cannot be decoded: https%3A%2F%2spark.apache.org. Please ensure that the URL is properly formatted and try again. SQLSTATE: 22546 at org.apache.spark.sql.errors.QueryExecutionErrors$.illegalUrlError(QueryExecutionErrors.scala:372) at org.apache.spark.sql.catalyst.expressions.UrlCodec$.decode(urlExpressions.scala:119) at org.apache.spark.sql.catalyst.expressions.UrlCodec.decode(urlExpressions.scala) ... Caused by: java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - Error at index 1 in: "2s" at java.base/java.net.URLDecoder.decode(URLDecoder.java:237) at java.base/java.net.URLDecoder.decode(URLDecoder.java:147) at org.apache.spark.sql.catalyst.expressions.UrlCodec$.decode(urlExpressions.scala:116) ... 135 more ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? unit test ### Was this patch authored or co-authored using generative AI tooling? No Closes #47211 from wForget/SPARK-48806. Lead-authored-by: wforget <643348094@qq.com> Co-authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org> (cherry picked from commit 310f8ea) Signed-off-by: Kent Yao <yao@apache.org>
|
Merged to master and 3.5. Thank you @wForget |
jerryzhou196
pushed a commit
to jerryzhou196/spark
that referenced
this pull request
Jul 4, 2024
### What changes were proposed in this pull request? Pass actual exception for url_decode. Follow-up to https://issues.apache.org/jira/browse/SPARK-40156 ### Why are the changes needed? Currently url_decode function ignores actual exception, which contains information that is useful for quickly locating the problem. Like executing this sql: ``` select url_decode('https%3A%2F%2spark.apache.org'); ``` We only get the error message: ``` org.apache.spark.SparkIllegalArgumentException: [CANNOT_DECODE_URL] The provided URL cannot be decoded: https%3A%2F%2spark.apache.org. Please ensure that the URL is properly formatted and try again. at org.apache.spark.sql.errors.QueryExecutionErrors$.illegalUrlError(QueryExecutionErrors.scala:376) at org.apache.spark.sql.catalyst.expressions.UrlCodec$.decode(urlExpressions.scala:118) at org.apache.spark.sql.catalyst.expressions.UrlCodec.decode(urlExpressions.scala) ``` However, the actual useful exception information is ignored: ``` java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - Error at index 1 in: "2s" ``` After this pr we will get: ``` org.apache.spark.SparkIllegalArgumentException: [CANNOT_DECODE_URL] The provided URL cannot be decoded: https%3A%2F%2spark.apache.org. Please ensure that the URL is properly formatted and try again. SQLSTATE: 22546 at org.apache.spark.sql.errors.QueryExecutionErrors$.illegalUrlError(QueryExecutionErrors.scala:372) at org.apache.spark.sql.catalyst.expressions.UrlCodec$.decode(urlExpressions.scala:119) at org.apache.spark.sql.catalyst.expressions.UrlCodec.decode(urlExpressions.scala) ... Caused by: java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - Error at index 1 in: "2s" at java.base/java.net.URLDecoder.decode(URLDecoder.java:237) at java.base/java.net.URLDecoder.decode(URLDecoder.java:147) at org.apache.spark.sql.catalyst.expressions.UrlCodec$.decode(urlExpressions.scala:116) ... 135 more ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? unit test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47211 from wForget/SPARK-48806. Lead-authored-by: wforget <643348094@qq.com> Co-authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org> Signed-off-by: Jerry Zhou <j448zhou@uwaterloo.ca>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Jul 10, 2024
### What changes were proposed in this pull request? Pass actual exception for url_decode. Follow-up to https://issues.apache.org/jira/browse/SPARK-40156 ### Why are the changes needed? Currently url_decode function ignores actual exception, which contains information that is useful for quickly locating the problem. Like executing this sql: ``` select url_decode('https%3A%2F%2spark.apache.org'); ``` We only get the error message: ``` org.apache.spark.SparkIllegalArgumentException: [CANNOT_DECODE_URL] The provided URL cannot be decoded: https%3A%2F%2spark.apache.org. Please ensure that the URL is properly formatted and try again. at org.apache.spark.sql.errors.QueryExecutionErrors$.illegalUrlError(QueryExecutionErrors.scala:376) at org.apache.spark.sql.catalyst.expressions.UrlCodec$.decode(urlExpressions.scala:118) at org.apache.spark.sql.catalyst.expressions.UrlCodec.decode(urlExpressions.scala) ``` However, the actual useful exception information is ignored: ``` java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - Error at index 1 in: "2s" ``` After this pr we will get: ``` org.apache.spark.SparkIllegalArgumentException: [CANNOT_DECODE_URL] The provided URL cannot be decoded: https%3A%2F%2spark.apache.org. Please ensure that the URL is properly formatted and try again. SQLSTATE: 22546 at org.apache.spark.sql.errors.QueryExecutionErrors$.illegalUrlError(QueryExecutionErrors.scala:372) at org.apache.spark.sql.catalyst.expressions.UrlCodec$.decode(urlExpressions.scala:119) at org.apache.spark.sql.catalyst.expressions.UrlCodec.decode(urlExpressions.scala) ... Caused by: java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - Error at index 1 in: "2s" at java.base/java.net.URLDecoder.decode(URLDecoder.java:237) at java.base/java.net.URLDecoder.decode(URLDecoder.java:147) at org.apache.spark.sql.catalyst.expressions.UrlCodec$.decode(urlExpressions.scala:116) ... 135 more ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? unit test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47211 from wForget/SPARK-48806. Lead-authored-by: wforget <643348094@qq.com> Co-authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? Pass actual exception for url_decode. Follow-up to https://issues.apache.org/jira/browse/SPARK-40156 ### Why are the changes needed? Currently url_decode function ignores actual exception, which contains information that is useful for quickly locating the problem. Like executing this sql: ``` select url_decode('https%3A%2F%2spark.apache.org'); ``` We only get the error message: ``` org.apache.spark.SparkIllegalArgumentException: [CANNOT_DECODE_URL] The provided URL cannot be decoded: https%3A%2F%2spark.apache.org. Please ensure that the URL is properly formatted and try again. at org.apache.spark.sql.errors.QueryExecutionErrors$.illegalUrlError(QueryExecutionErrors.scala:376) at org.apache.spark.sql.catalyst.expressions.UrlCodec$.decode(urlExpressions.scala:118) at org.apache.spark.sql.catalyst.expressions.UrlCodec.decode(urlExpressions.scala) ``` However, the actual useful exception information is ignored: ``` java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - Error at index 1 in: "2s" ``` After this pr we will get: ``` org.apache.spark.SparkIllegalArgumentException: [CANNOT_DECODE_URL] The provided URL cannot be decoded: https%3A%2F%2spark.apache.org. Please ensure that the URL is properly formatted and try again. SQLSTATE: 22546 at org.apache.spark.sql.errors.QueryExecutionErrors$.illegalUrlError(QueryExecutionErrors.scala:372) at org.apache.spark.sql.catalyst.expressions.UrlCodec$.decode(urlExpressions.scala:119) at org.apache.spark.sql.catalyst.expressions.UrlCodec.decode(urlExpressions.scala) ... Caused by: java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - Error at index 1 in: "2s" at java.base/java.net.URLDecoder.decode(URLDecoder.java:237) at java.base/java.net.URLDecoder.decode(URLDecoder.java:147) at org.apache.spark.sql.catalyst.expressions.UrlCodec$.decode(urlExpressions.scala:116) ... 135 more ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? unit test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47211 from wForget/SPARK-48806. Lead-authored-by: wforget <643348094@qq.com> Co-authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Pass actual exception for url_decode.
Follow-up to https://issues.apache.org/jira/browse/SPARK-40156
Why are the changes needed?
Currently url_decode function ignores actual exception, which contains information that is useful for quickly locating the problem.
Like executing this sql:
We only get the error message:
However, the actual useful exception information is ignored:
After this pr we will get:
Does this PR introduce any user-facing change?
No
How was this patch tested?
unit test
Was this patch authored or co-authored using generative AI tooling?
No