[SPARK-48808][SQL] Fix NPE when connecting thriftserver through Hive 1.2.1 and the result schema is empty #47213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1.2.1 and 0 column outputs
|
cc @wangyum |
|
Thank you @wangyum for the review and test. Merged to master |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Jul 10, 2024
…1.2.1 and the result schema is empty ### What changes were proposed in this pull request? Lower Hive JDBC/Thrift Client doesn't test whether columns are null or not before handling it. In this PR, we set an empty list to it if the result schema is empty ### Why are the changes needed? bugfix for lower hive clients ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? tested offline by wangyum ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47213 from yaooqinn/SPARK-48808. Lead-authored-by: Kent Yao <yao@apache.org> Co-authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Kent Yao <yao@apache.org>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…1.2.1 and the result schema is empty ### What changes were proposed in this pull request? Lower Hive JDBC/Thrift Client doesn't test whether columns are null or not before handling it. In this PR, we set an empty list to it if the result schema is empty ### Why are the changes needed? bugfix for lower hive clients ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? tested offline by wangyum ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47213 from yaooqinn/SPARK-48808. Lead-authored-by: Kent Yao <yao@apache.org> Co-authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Lower Hive JDBC/Thrift Client doesn't test whether columns are null or not before handling it. In this PR, we set an empty list to it if the result schema is empty
Why are the changes needed?
bugfix for lower hive clients
Does this PR introduce any user-facing change?
no
How was this patch tested?
tested offline by @wangyum
Was this patch authored or co-authored using generative AI tooling?
no