[SPARK-48719][SQL][3.5] Fix the calculation bug of RegrSlope & RegrIntercept when the first parameter is null #47230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan, all checks have passed |
cloud-fan
approved these changes
Jul 8, 2024
|
thanks, merging to 3.5! |
cloud-fan
pushed a commit
that referenced
this pull request
Jul 8, 2024
…tercept when the first parameter is null ### What changes were proposed in this pull request? This PR aims to fix the calculation bug of RegrSlope&RegrIntercept when the first parameter is null. Regardless of whether the first parameter(y) or the second parameter(x) is null, this tuple should be filtered out. ### Why are the changes needed? Fix bug. ### Does this PR introduce _any_ user-facing change? Yes, the calculation changes when the first value of a tuple is null, but the value is truly correct. ### How was this patch tested? Pass GA and test with build/sbt "~sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z linear-regression.sql" ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47230 from wayneguow/SPARK-48719_3_5. Authored-by: Wei Guo <guow93@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix the calculation bug of RegrSlope&RegrIntercept when the first parameter is null. Regardless of whether the first parameter(y) or the second parameter(x) is null, this tuple should be filtered out.
Why are the changes needed?
Fix bug.
Does this PR introduce any user-facing change?
Yes, the calculation changes when the first value of a tuple is null, but the value is truly correct.
How was this patch tested?
Pass GA and test with build/sbt "~sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z linear-regression.sql"
Was this patch authored or co-authored using generative AI tooling?
No.