[SPARK-48823][DOCS] Improve clarity in lag docstring
#47236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Good catch. Could you please create a JIRA ticket under SPARK-44728?
|
@allisonwang-db Thanks! Sub ticket SPARK-48823 created. |
allisonwang-db
approved these changes
Jul 5, 2024
|
@thomhart31 thanks! please also add this JIRA in the PR title "[[SPARK-48823]..." |
thomhart31
changed the title
lag docstringlag docstring
allisonwang-db
approved these changes
Jul 8, 2024
yaooqinn
changed the title
lag docstringlag docstring
yaooqinn
approved these changes
Jul 10, 2024
|
Merged to master, Thank you @thomhart31 @allisonwang-db |
|
Sorry, I reverted this by 0fdebcc because the new format is incorrect. |
biruktesf-db
pushed a commit
to biruktesf-db/spark
that referenced
this pull request
Jul 11, 2024
### What changes were proposed in this pull request? This PR edits grammar in `pyspark.sql.functions.lag` docstring. ### Why are the changes needed? To improve the documentation. ### Does this PR introduce any user-facing change? No changes in behavior are introduced. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47236 from thomhart31/docs-lag. Authored-by: thomas.hart <thomas.hart@databricks.com> Signed-off-by: Kent Yao <yao@apache.org>
jingz-db
pushed a commit
to jingz-db/spark
that referenced
this pull request
Jul 22, 2024
### What changes were proposed in this pull request? This PR edits grammar in `pyspark.sql.functions.lag` docstring. ### Why are the changes needed? To improve the documentation. ### Does this PR introduce any user-facing change? No changes in behavior are introduced. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47236 from thomhart31/docs-lag. Authored-by: thomas.hart <thomas.hart@databricks.com> Signed-off-by: Kent Yao <yao@apache.org>
|
What is the current status of this PR, @thomhart31 and @yaooqinn ? Since we found that the content itself is invalid, do you want to update or shall we close this for now? |
|
Thank you, @dongjoon-hyun, for the reminder. I have committed a fix for the style issue. Hopefully, it can pass the GA. |
yaooqinn
approved these changes
Sep 9, 2024
|
Merged to master. Thank you @thomhart31 @dongjoon-hyun @allisonwang-db |
IvanK-db
pushed a commit
to IvanK-db/spark
that referenced
this pull request
Sep 20, 2024
### What changes were proposed in this pull request? This PR edits grammar in `pyspark.sql.functions.lag` docstring. ### Why are the changes needed? To improve the documentation. ### Does this PR introduce any user-facing change? No changes in behavior are introduced. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47236 from thomhart31/docs-lag. Lead-authored-by: thomas.hart <thomas.hart@databricks.com> Co-authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? This PR edits grammar in `pyspark.sql.functions.lag` docstring. ### Why are the changes needed? To improve the documentation. ### Does this PR introduce any user-facing change? No changes in behavior are introduced. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47236 from thomhart31/docs-lag. Authored-by: thomas.hart <thomas.hart@databricks.com> Signed-off-by: Kent Yao <yao@apache.org>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? This PR edits grammar in `pyspark.sql.functions.lag` docstring. ### Why are the changes needed? To improve the documentation. ### Does this PR introduce any user-facing change? No changes in behavior are introduced. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47236 from thomhart31/docs-lag. Lead-authored-by: thomas.hart <thomas.hart@databricks.com> Co-authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR edits grammar in
pyspark.sql.functions.lagdocstring.Why are the changes needed?
To improve the documentation.
Does this PR introduce any user-facing change?
No changes in behavior are introduced.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No