Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][SPARK-48353][SQL] Introduction of Error Handling mechanism in SQL Scripting #47423
base: master
Are you sure you want to change the base?
[WIP][SPARK-48353][SQL] Introduction of Error Handling mechanism in SQL Scripting #47423
Changes from 97 commits
0dea6c6
d7b1950
0872769
dd20a7e
0117228
bd2a907
746e04b
3126baf
df563bd
6d402fc
5a2055f
fcbc98d
a98259a
14ec8e0
b4638a8
57c446e
d663024
3989e12
623cd2b
214c685
e888bab
b417ddf
55e34d7
8f24084
45294b0
e65123b
435454d
5d95075
83f6651
f497be9
f0c2026
8488904
1392a76
1e45373
75bfb62
428570b
0571f3a
f65ecd7
46e41e8
b9d74b9
3c4c9de
874ed32
5d9c4d1
41df74e
7557dd2
02579c9
f2fb470
6f71896
2c1ab0d
a1028bb
e3f3638
b749f95
b6f4740
0845967
e49716e
03ba9e3
1fd896b
458d45f
c707776
655543b
0f0389a
04d6031
a32df9c
e391ee7
ef89698
4905fa3
a4f9ac6
df6e5fd
b412d40
c758a62
a6571e3
b90e159
1a22353
f452cc1
574b3da
b1d867d
156a2d7
62f230c
6a37dcc
fa82a44
b5516e4
56ca9fd
6962986
29b4f3d
17282c4
736e481
3b6dca0
67fd0d4
9675b3d
47485ff
cbe2f0f
564f584
5c519c1
c807359
0dddefc
5ad3474
e8d9506
dc7f521
29f1afb
5389e0c
12bdede
2e07461
c0c2d5d
a1573f6
7598e0f
3e3373d
bf9f409
ff0f330
a81a64e
48c5929
e7ac5ad
97c0f5c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you get the current config value from the active config obj
conf
? See other examples in the same file likeconf.getConf(SQLConf.ENABLE_DEFAULT_COLUMNS)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be rebased on: #47609. Can you please leave comments there first, and then we can get back to this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we miss a logic for statement ordering? i.e. if I recall correctly, we should have variable and condition declarations first, followed by handler declarations, and the actual body afterwards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that check is missing at the moment. It will be added.