[SPARK-49078][SQL] Support show columns syntax in v2 table #47568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzifu666
force-pushed
the
support_show_columns_v2
branch
from
e88c610
to
d057408
Compare
|
|
yaooqinn
reviewed
Aug 2, 2024
...core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowColumnsTableExec.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Aug 2, 2024
...core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowColumnsTableExec.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Aug 2, 2024
...core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowColumnsTableExec.scala
Outdated
Show resolved
Hide resolved
|
Also cc @cloud-fan |
yaooqinn
reviewed
Aug 2, 2024
...core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowColumnsTableExec.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Aug 2, 2024
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Aug 2, 2024
...core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowColumnsTableExec.scala
Outdated
Show resolved
Hide resolved
|
Can you retrigger the CI? |
OK i try it@yaooqinn |
xuzifu666
force-pushed
the
support_show_columns_v2
branch
from
80c10b8
to
e19cfc4
Compare
…rces/v2/ShowColumnsTableExec.scala
…rceV2SQLSuite.scala
…rces/v2/ShowColumnsTableExec.scala
xuzifu666
force-pushed
the
support_show_columns_v2
branch
from
e19cfc4
to
9ed9261
Compare
|
Merged to master, thank you @xuzifu666 |
|
late LGTM |
fusheng-rd
pushed a commit
to fusheng-rd/spark
that referenced
this pull request
Aug 6, 2024
### What changes were proposed in this pull request? Support v2 table with show columns syntax. ### Why are the changes needed? In lakehouse format such as Paimon、Iceberg，table are v2 which not support show column syntax，this pr is aimed to support it ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? DataSourceV2SQLSuite ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47568 from xuzifu666/support_show_columns_v2. Lead-authored-by: xuyu <11161569@vivo.com> Co-authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 12, 2024
…2TablesError in QueryCompilationErrors and add more uts ### What changes were proposed in this pull request? Clear unused error methods in QueryCompilationErrors. ### Why are the changes needed? Due to had support show columns in v2 table(#47568), so the check method is not needed any more. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? not need ### Was this patch authored or co-authored using generative AI tooling? Closes #47701 from xuzifu666/rm_showcolumnsv2. Lead-authored-by: xuyu <11161569@vivo.com> Co-authored-by: xuzifu666 <1206332514@qq.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
IvanK-db
pushed a commit
to IvanK-db/spark
that referenced
this pull request
Sep 20, 2024
…2TablesError in QueryCompilationErrors and add more uts ### What changes were proposed in this pull request? Clear unused error methods in QueryCompilationErrors. ### Why are the changes needed? Due to had support show columns in v2 table(apache#47568), so the check method is not needed any more. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? not need ### Was this patch authored or co-authored using generative AI tooling? Closes apache#47701 from xuzifu666/rm_showcolumnsv2. Lead-authored-by: xuyu <11161569@vivo.com> Co-authored-by: xuzifu666 <1206332514@qq.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? Support v2 table with show columns syntax. ### Why are the changes needed? In lakehouse format such as Paimon、Iceberg，table are v2 which not support show column syntax，this pr is aimed to support it ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? DataSourceV2SQLSuite ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47568 from xuzifu666/support_show_columns_v2. Lead-authored-by: xuyu <11161569@vivo.com> Co-authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…2TablesError in QueryCompilationErrors and add more uts ### What changes were proposed in this pull request? Clear unused error methods in QueryCompilationErrors. ### Why are the changes needed? Due to had support show columns in v2 table(apache#47568), so the check method is not needed any more. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? not need ### Was this patch authored or co-authored using generative AI tooling? Closes apache#47701 from xuzifu666/rm_showcolumnsv2. Lead-authored-by: xuyu <11161569@vivo.com> Co-authored-by: xuzifu666 <1206332514@qq.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support v2 table with show columns syntax.
Why are the changes needed?
In lakehouse format such as Paimon、Iceberg，table are v2 which not support show column syntax，this pr is aimed to support it
Does this PR introduce any user-facing change?
No
How was this patch tested?
DataSourceV2SQLSuite
Was this patch authored or co-authored using generative AI tooling?
no