Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-49222][SQL] Clear useless methods in QueryCompilationErrors #47740

Closed
wants to merge 5 commits into from
Closed

[SPARK-49222][SQL] Clear useless methods in QueryCompilationErrors #47740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f21641
[SPARK-49222][SQL] Clear useless methods in QueryCompilationErrors
Aug 13, 2024
96bc9cc
remove var
Aug 13, 2024
59d7d9a
fix
Aug 13, 2024
6d800e9
recovery
Aug 14, 2024
1f6e7c6
recovery
Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions common/utils/src/main/resources/error/error-conditions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,12 +388,6 @@
],
"sqlState" : "58030"
},
"CANNOT_SAVE_VARIANT" : {
"message" : [
"Cannot save variant data type into external storage."
],
"sqlState" : "0A000"
},
"CANNOT_UPDATE_FIELD" : {
"message" : [
"Cannot update <table> field <fieldName> type:"
Expand Down
13 changes: 0 additions & 13 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,13 +203,6 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase with Compilat
invalidParameter("DOUBLE", "ewm", "alpha", invalidValue)
}

def invalidStringParameter(
functionName: String,
parameter: String,
invalidValue: Expression): Throwable = {
invalidParameter("STRING", functionName, parameter, invalidValue)
}

def invalidParameter(
subClass: String,
functionName: String,
Expand Down Expand Up @@ -1679,12 +1672,6 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase with Compilat
messageParameters = Map.empty)
}

def cannotSaveVariantIntoExternalStorageError(): Throwable = {
new AnalysisException(
errorClass = "CANNOT_SAVE_VARIANT",
messageParameters = Map.empty)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these two error message templates, CANNOT_SAVE_VARIANT and INDETERMINATE_COLLATION, still needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CANNOT_SAVE_VARIANT can be remove，but INDETERMINATE_COLLATION still in CollationIdentifier which maybe needed. I remove CANNOT_SAVE_VARIANT firstly? @LuciferYang

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CollationIdentifier? INDETERMINATE_COLLATION_ID?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK，let's remove INDETERMINATE_COLLATION from error-conditions.json @LuciferYang

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}

def cannotResolveAttributeError(name: String, outputStr: String): Throwable = {
new AnalysisException(
errorClass = "_LEGACY_ERROR_TEMP_1137",
Expand Down