[SPARK-49523][CONNECT] Increase maximum wait time for connect server to come up for testing #47994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WweiL mind filing a JIRA please? |
|
Ok, let's get this one merged. I will file the JIRA and update the description. |
hvanhovell
reviewed
Sep 5, 2024
| .build()) | ||
| .create() | ||
|
|
||
| // Execute an RPC which will get retried until the server is up. | ||
| assert(spark.version == SparkBuildInfo.spark_version) | ||
| eventually(timeout(1.minute)) { |
There was a problem hiding this comment.
Basically this adds another layer of retries. We could also set the maxBackoff to 1 minute.
hvanhovell
changed the title
|
Oops... thanks guys! |
IvanK-db
pushed a commit
to IvanK-db/spark
that referenced
this pull request
Sep 20, 2024
…to come up for testing ### What changes were proposed in this pull request? This PR increases the max time we wait for a connect server to come up for testing. The current threshold is too low, and is causing flakyness. ### Why are the changes needed? It makes connect tests less flaky. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? It is test infra code. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47994 from WweiL/deflake-will-it-work. Authored-by: Wei Liu <wei.liu@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…to come up for testing ### What changes were proposed in this pull request? This PR increases the max time we wait for a connect server to come up for testing. The current threshold is too low, and is causing flakyness. ### Why are the changes needed? It makes connect tests less flaky. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? It is test infra code. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47994 from WweiL/deflake-will-it-work. Authored-by: Wei Liu <wei.liu@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR increases the max time we wait for a connect server to come up for testing. The current threshold is too low, and is causing flakyness.
Why are the changes needed?
It makes connect tests less flaky.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
It is test infra code.
Was this patch authored or co-authored using generative AI tooling?
No.