[SPARK-49873][SQL] Assign proper error class for _LEGACY_ERROR_TEMP_1325 #48346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
reviewed
Oct 4, 2024
There was a problem hiding this comment.
@itholic Could you fix the failed tests:
[info] - cannot set/unset static SQL conf *** FAILED *** (5 milliseconds)
[info] "[CANNOT_MODIFY_CONFIG] Cannot modify the value of the Spark config: spark.sql.globalTempDatabase.
[info] See also 'https://spark.apache.org/docs/latest/sql-migration-guide.html#ddl-statements'. SQLSTATE: 46110" did not contain "Cannot modify the value of a static config" (SQLConfSuite.scala:319)
MaxGekk
requested changes
Oct 5, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
itholic
commented
Oct 9, 2024
| "Cannot modify the value of a static config: spark.sql.hive.thriftServer.singleSession")) | ||
| "CANNOT_MODIFY_CONFIG")) |
There was a problem hiding this comment.
I tried to retrieve the root case by using getCause to use checkError, but seems like the SQLException just returns null
|
I think the failed test is not related to your changes: I re-ran it locally. +1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to assign proper error class for _LEGACY_ERROR_TEMP_1325
Why are the changes needed?
To improve user facing error message by providing proper error condition and sql state
Does this PR introduce any user-facing change?
Improve user-facing error message
How was this patch tested?
Updated the existing UT
Was this patch authored or co-authored using generative AI tooling?
No