[Streaming][Minor]Fix some error docs in streaming examples #4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #28134 has started for PR 4837 at commit
|
| @@ -23,7 +23,7 @@ | |||
| http://kafka.apache.org/documentation.html#quickstart | |||
| and then run the example | |||
| `$ bin/spark-submit --driver-class-path external/kafka-assembly/target/scala-*/\ | |||
| `$ bin/spark-submit --jars external/kafka-assembly/target/scala-*/\ | |||
There was a problem hiding this comment.
Am I right that this is the right example for 1.3+ only?
There was a problem hiding this comment.
Yes, python Kafka API is added in 1.3 and using --driver-class-path is not correct, need to change to --jars.
There was a problem hiding this comment.
OK, so this should be merged for 1.3+, but not 1.2?
|
Test build #28134 has finished for PR 4837 at commit
|
|
Test PASSed. |
asfgit
pushed a commit
that referenced
this pull request
Mar 2, 2015
Small changes, please help to review, thanks a lot. Author: Saisai Shao <saisai.shao@intel.com> Closes #4837 from jerryshao/doc-fix and squashes the following commits: 545291a [Saisai Shao] Fix some error docs in streaming examples (cherry picked from commit d8fb40e) Signed-off-by: Sean Owen <sowen@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes, please help to review, thanks a lot.