-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-49558][SQL] Add SQL pipe syntax for LIMIT/OFFSET and ORDER/SORT/CLUSTER/DISTRIBUTE BY #48413
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4926,6 +4926,11 @@ | |
"Catalog <catalogName> does not support <operation>." | ||
] | ||
}, | ||
"CLAUSE_WITH_PIPE_OPERATORS" : { | ||
"message" : [ | ||
"The SQL pipe operator syntax using |> does not support <clauses>." | ||
] | ||
}, | ||
"COMBINATION_QUERY_RESULT_CLAUSES" : { | ||
"message" : [ | ||
"Combination of ORDER BY/SORT BY/DISTRIBUTE BY/CLUSTER BY." | ||
cloud-fan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
@@ -5006,6 +5011,11 @@ | |
"Multiple bucket TRANSFORMs." | ||
] | ||
}, | ||
"MULTIPLE_QUERY_RESULT_CLAUSES_WITH_PIPE_OPERATORS" : { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shall we turn it into a top-level error class? This is syntax error, not unsupported feature, and should have a different SQL state. |
||
"message" : [ | ||
"Syntax error: the SQL pipe operator syntax using |> does not support <clauses>. Please separate the multiple result clauses into separate pipe operators and then retry the query again." | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. how about
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The idea is to make the error parameters simple, so that people can consume it programatically. |
||
] | ||
}, | ||
"MULTI_ACTION_ALTER" : { | ||
"message" : [ | ||
"The target JDBC server hosting table <tableName> does not support ALTER TABLE with multiple actions. Split the ALTER TABLE up into individual actions to avoid this error." | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe @srielau can also comment here, but it looks to me that we have two new errors:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, 2 is a syntax error for the pipe statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, split this into two new errors per suggestion.