[SPARK-49975][SQL] Disallow LEGACY storeAssignmentPolicy with DataFrameWriterV2 API #48476
+29
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan @yaooqinn @wangyum The following is allowed with legacy store assignment policy after #47082 CREATE TABLE testcat.ns.t1 (d1 string, d2 varchar(200)) USING parquet;
CREATE TABLE testcat.ns.t2 USING foo as select * from testcat.ns.t1;I'm wondering to what extent is the policy allowed in data source v2. |
cloud-fan
reviewed
Oct 16, 2024
| checkError( | ||
| exception = intercept[AnalysisException] { | ||
| spark.range(10) | ||
| .writeTo("table_name") |
There was a problem hiding this comment.
what was the behavior before? Do we add hard cast for the input query?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Before this PR, store assignment policy is validated for
V2Writecommand whenv2Write.table.resolved && v2Write.query.resolved && !v2Write.outputResolvedis true. However,!v2Write.outputResolveddoesn't hold for DataFrameWriterV2 API and the policy is not validated. This PR validates store assignment policy forV2Writecommand without any conditions.Why are the changes needed?
LEGACY store assignment policy should not be allowed writing to v2 table with DataFrameWriterV2 API.
Does this PR introduce any user-facing change?
An
AnalysisErrorwill be thrown when users write to v2 table with DataFrameWriterV2 API andspark.sql.storeAssignmentPolicy=LEGACYHow was this patch tested?
UT.
Was this patch authored or co-authored using generative AI tooling?
No.