[SPARK-49987][SQL] Fix the error prompt when seedExpression is non-foldable in randstr

[panbingkun]

What changes were proposed in this pull request?

The pr aims to

• fix the error prompt when seedExpression is non-foldable in randstr.
• use toSQLId to set the parameter value inputName for randstr and uniform of NON_FOLDABLE_INPUT.

Why are the changes needed?

• Let me take an example

val df = Seq(1.1).toDF("a")
df.createOrReplaceTempView("t")
sql("SELECT randstr(1, a) from t").show(false)

• Before

[DATATYPE_MISMATCH.NON_FOLDABLE_INPUT] Cannot resolve "randstr(1, a)" due to data type mismatch: the input seedExpression should be a foldable INT or SMALLINT expression; however, got "a". SQLSTATE: 42K09; line 1 pos 7;
'Project [unresolvedalias(randstr(1, a#5, false))]
+- SubqueryAlias t
   +- View (`t`, [a#5])
      +- Project [value#1 AS a#5]
         +- LocalRelation [value#1]

• After

[DATATYPE_MISMATCH.NON_FOLDABLE_INPUT] Cannot resolve "randstr(1, a)" due to data type mismatch: the input seed should be a foldable INT or SMALLINT expression; however, got "a". SQLSTATE: 42K09; line 1 pos 7;
'Project [unresolvedalias(randstr(1, a#5, false))]
+- SubqueryAlias t
   +- View (`t`, [a#5])
      +- Project [value#1 AS a#5]
         +- LocalRelation [value#1]

• The parameter name (seedExpression) in the error message does not match the parameter name (seed) seen in docs by the end-user.

Does this PR introduce any user-facing change?

Yes, When seed is non-foldable , the end-user will get a consistent experience in the error prompt.

How was this patch tested?

Update existed UT.

Was this patch authored or co-authored using generative AI tooling?

No.

[panbingkun]

cc @dtenedor @MaxGekk

[MaxGekk]

Since it is an id, could you quote it using to toSQLId(), please at:

                "inputName" -> toSQLId(name),

[panbingkun]

Okay

[panbingkun]

Given this, let me update Uniform's name in this PR as well:

spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala

Line 266 in 861b5e9

"inputName" -> name,

[MaxGekk]

Waiting for CI.

[MaxGekk]

It seems the failed tests is related:

[info] - randstr function *** FAILED *** (181 milliseconds)
[info]   Map("inputName" -> "`length`", "inputType" -> "INT or SMALLINT", "inputExpr" -> ""a"", "sqlExpr" -> ""randstr(a, 10)"") did not equal Map("inputName" -> "length", "inputType" -> "INT or SMALLINT", "inputExpr" -> ""a"", "sqlExpr" -> ""randstr(a, 10)"") (SparkFunSuite.scala:362)

[panbingkun]

It seems the failed tests is related:

[info] - randstr function *** FAILED *** (181 milliseconds)
[info]   Map("inputName" -> "`length`", "inputType" -> "INT or SMALLINT", "inputExpr" -> ""a"", "sqlExpr" -> ""randstr(a, 10)"") did not equal Map("inputName" -> "length", "inputType" -> "INT or SMALLINT", "inputExpr" -> ""a"", "sqlExpr" -> ""randstr(a, 10)"") (SparkFunSuite.scala:362)

Thanks!
Yes, I have fixed it, waiting for CI.

[MaxGekk]

+1, LGTM. Merging to master.
Thank you, @panbingkun.