[SPARK-49988][BUILD] Remove unused Hadoop dependency management #48491
+6
−334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
reviewed
Oct 16, 2024
| --> | ||
| <dependency> | ||
| <groupId>xerces</groupId> | ||
| <artifactId>xercesImpl</artifactId> |
There was a problem hiding this comment.
Is it because Apache Spark doesn't require the xerces:xercesImpl dependency?
There was a problem hiding this comment.
If that's the case, should we clean up the corresponding binary LICENSE of xerces:xercesImpl ?
There was a problem hiding this comment.
it's a transitive dep of hadoop vanilla client, spark does not directly use it.
There was a problem hiding this comment.
right, updated LICENSE and NOTICE
There was a problem hiding this comment.
It would be best to declare this change in the pr description.
LuciferYang
approved these changes
Oct 16, 2024
|
@dongjoon-hyun I tested the maven build, run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove unused vanilla hadoop dependency(and transitive deps) management, i.e.
hadoop-client,xerces:xercesImpl, and inline deps defined inhadoop3because it's the only supported hadoop profile.Why are the changes needed?
Simplify pom.xml.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass CI and verified runtime jars are not affected by running
dev/test-dependencies.sh.Was this patch authored or co-authored using generative AI tooling?
No.