[SPARK-49991][SQL] Make HadoopMapReduceCommitProtocol respect 'mapreduce.output.basename' to generate file names #48494
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uce.output.basename' to generate file names
…uce.output.basename' to generate file names
|
cc @cloud-fan @dongjoon-hyun, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In 'HadoopMapReduceCommitProtocol', task output files are generated ahead instead of calling
org.apache.hadoop.mapreduce.lib.output.FileOutputFormat#getDefaultWorkFile, which uses themapreduce.output.basenameas the prefix of output files.In this pull request, we modify the
HadoopMapReduceCommitProtocol.getFilenamemethod to also look up this config instead of using the hardcoded 'part'.Why are the changes needed?
Given a custom file name is a useful feature for users. They can use it to distinguish files added by different engines, on different days, etc. We can also align the usage scenario with other SQL on Hadoop engines for better Hadoop compatibility.
Does this PR introduce any user-facing change?
Yes, a Hadoop configuration 'mapreduce.output.basename' can be used in file datasource output files
How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
no`