-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-50879][ML][PYTHON][CONNECT] Support feature scalers on Connect #49581
Conversation
@@ -240,6 +240,8 @@ sealed trait Vector extends Serializable { | |||
@Since("2.0.0") | |||
object Vectors { | |||
|
|||
private[ml] val empty: Vector = zeros(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, we can change it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
8cda52c
to
2450f08
Compare
### What changes were proposed in this pull request? Support feature scalers on Connect: - org.apache.spark.ml.feature.StandardScaler - org.apache.spark.ml.feature.MaxAbsScaler - org.apache.spark.ml.feature.MinMaxScaler ### Why are the changes needed? for feature parity ### Does this PR introduce _any_ user-facing change? yes, new algorithms supported on connect ### How was this patch tested? added tests ### Was this patch authored or co-authored using generative AI tooling? no Closes #49581 from zhengruifeng/ml_connect_scaler. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org> (cherry picked from commit 6d66f26) Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
thanks, merged to master/4.0 |
What changes were proposed in this pull request?
Support feature scalers on Connect:
Why are the changes needed?
for feature parity
Does this PR introduce any user-facing change?
yes, new algorithms supported on connect
How was this patch tested?
added tests
Was this patch authored or co-authored using generative AI tooling?
no