[SPARK-50884][ML][PYTHON][CONNECT] Support isLargerBetter in Evaluator #49620
+83
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/pyspark/ml/evaluation.py
Outdated
Comment on lines
474
to
476
| if self.getMetricName() in ["r2", "var"]: | ||
| return True | ||
| return False |
There was a problem hiding this comment.
Suggested change
| if self.getMetricName() in ["r2", "var"]: | |
| return True | |
| return False | |
| return self.getMetricName() in ["r2", "var"] |
we can simplify it a bit
zhengruifeng
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support isLargerBetter in Evaluator
Why are the changes needed?
for parity feature
Does this PR introduce any user-facing change?
No
How was this patch tested?
The newly added tests pass
Was this patch authored or co-authored using generative AI tooling?
No