[SPARK-50963][ML][PYTHON][CONNECT] Support Tokenizers, SQLTransform and StopWordsRemover on Connect #49624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
commented
Jan 23, 2025
python/pyspark/ml/feature.py
Outdated
| @@ -5072,7 +5073,7 @@ def __init__( | |||
| self._setDefault( | |||
| stopWords=StopWordsRemover.loadDefaultStopWords("english"), | |||
| caseSensitive=False, | |||
| locale=self._java_obj.getLocale(), | |||
| locale="en_US" if isinstance(self._java_obj, str) else self._java_obj.getLocale(), | |||
There was a problem hiding this comment.
PySpark Classic calls the jvm side to get the default value
spark/mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala
Lines 129 to 138 in e7e0826
which is not available in Connect Mode.
There was a problem hiding this comment.
let me rethink here, if we skip _setDefault locale, then remover.getLocale() fails if user does not explicitly set it, but it will reuse the default value in the jvm side.
HyukjinKwon
approved these changes
Jan 24, 2025
zhengruifeng
added a commit
that referenced
this pull request
Jan 24, 2025
…nd StopWordsRemover on Connect ### What changes were proposed in this pull request? Support a group of text processing algorithms: - Tokenizer - RegexTokenizer - SQLTransform - StopWordsRemover ### Why are the changes needed? for feature parity ### Does this PR introduce _any_ user-facing change? yes ### How was this patch tested? added tests ### Was this patch authored or co-authored using generative AI tooling? no Closes #49624 from zhengruifeng/ml_connect_tokenizer. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org> (cherry picked from commit 42b15c9) Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
|
thanks. merged to master/4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support a group of text processing algorithms:
Why are the changes needed?
for feature parity
Does this PR introduce any user-facing change?
yes
How was this patch tested?
added tests
Was this patch authored or co-authored using generative AI tooling?
no