[Fix #79] Replace Breakable For Loops By While Loops #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Jenkins, test this please |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14406/ |
|
@mateiz retest this please, I think failure is due to some other PR, as these changes have nothing to do with Streaming. |
|
Jenkins, retest this please. |
| // Check whether all the nodes at the current level at leaves. | ||
| val allLeaf = splitsStatsForLevel.forall(_._2.gain <= 0) | ||
| logDebug("all leaf = " + allLeaf) | ||
| if (allLeaf) break = true // no more tree construction |
There was a problem hiding this comment.
per Spark style guide, can you change this to include curly braces, e.g.
if (allLeaf) {
break = true
} else {
level += 1
}Thanks.
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
@rxin all suggested changes done, tests passed |
|
Thanks. I've merged this. |
asfgit
pushed a commit
that referenced
this pull request
Apr 24, 2014
Author: Sandeep <sandeep@techaddict.me> Closes #503 from techaddict/fix-79 and squashes the following commits: e3f6746 [Sandeep] Style changes 07a4f6b [Sandeep] for loop to While loop 0a6d8e9 [Sandeep] Breakable for loop to While loop (cherry picked from commit bb68f47) Signed-off-by: Reynold Xin <rxin@apache.org>
pwendell
added a commit
to pwendell/spark
that referenced
this pull request
May 12, 2014
Fix bug on read-side of external sort when using Snappy. This case wasn't handled correctly and this patch fixes it.
pdeyhim
pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
Author: Sandeep <sandeep@techaddict.me> Closes apache#503 from techaddict/fix-79 and squashes the following commits: e3f6746 [Sandeep] Style changes 07a4f6b [Sandeep] for loop to While loop 0a6d8e9 [Sandeep] Breakable for loop to While loop
andrewor14
pushed a commit
to andrewor14/spark
that referenced
this pull request
Jan 8, 2015
Fix bug on read-side of external sort when using Snappy. This case wasn't handled correctly and this patch fixes it. (cherry picked from commit 3d6e754) Signed-off-by: Patrick Wendell <pwendell@gmail.com>
mccheah
referenced
this pull request
in palantir/spark
Sep 26, 2017
markhamstra
pushed a commit
to markhamstra/spark
that referenced
this pull request
Nov 7, 2017
bzhaoopenstack
pushed a commit
to bzhaoopenstack/spark
that referenced
this pull request
Sep 11, 2019
* Add support for config-gcc role
You can use below config to enbale gcc-7:
```
roles:
- role: config-gcc
gcc_version: 7
```
Close-issue: theopenlab/openlab#239
* Add periodic job for envoy and containerd
This patch add the periodic jobs for envoy and containerd arm
build.
- containerd-build-arm64
- envoy-build-arm64
arjunshroff
pushed a commit
to arjunshroff/spark
that referenced
this pull request
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.