-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-6862][Streaming][WebUI] Add BatchPage to display details of a batch #5473
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0c7b2eb
Add BatchPage to display details of a batch
zsxwing fc98a43
Put clearing local properties to finally and remove redundant private…
zsxwing 0b226f9
Change 'Last Error' to 'Error'
zsxwing 7168807
Limit the max width of the error message and fix nits in the UI
zsxwing 4bf66b6
Merge branch 'master' into SPARK-6862
zsxwing 15bdf9b
Add batch links and unit tests
zsxwing 35ffd80
Merge branch 'master' into SPARK-6862
zsxwing 77a69ae
Refactor codes as per TD's comments
zsxwing 1282b10
Handle some corner cases and add tests for StreamingJobProgressListener
zsxwing 72f8e7e
Add unit tests for BatchPage
zsxwing cb62e4f
Use Seq[(OutputOpId, SparkJobId)] to store the id relations
zsxwing 087ba98
Refactor BatchInfo to store only necessary fields
zsxwing 9a3083d
Rename XxxDatas -> XxxData
zsxwing b380cfb
Add createJobStart to eliminate duplicate codes
zsxwing 0727d35
Change BatchUIData to a case class
zsxwing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -172,16 +172,28 @@ class JobScheduler(val ssc: StreamingContext) extends Logging { | |
ssc.waiter.notifyError(e) | ||
} | ||
|
||
private class JobHandler(job: Job) extends Runnable { | ||
private class JobHandler(job: Job) extends Runnable with Logging { | ||
def run() { | ||
eventLoop.post(JobStarted(job)) | ||
// Disable checks for existing output directories in jobs launched by the streaming scheduler, | ||
// since we may need to write output to an existing directory during checkpoint recovery; | ||
// see SPARK-4835 for more details. | ||
PairRDDFunctions.disableOutputSpecValidation.withValue(true) { | ||
job.run() | ||
ssc.sc.setLocalProperty(JobScheduler.BATCH_TIME_PROPERTY_KEY, job.time.milliseconds.toString) | ||
ssc.sc.setLocalProperty(JobScheduler.OUTPUT_OP_ID_PROPERTY_KEY, job.outputOpId.toString) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This setting and clearing of property needs to be done in a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Put them to |
||
try { | ||
eventLoop.post(JobStarted(job)) | ||
// Disable checks for existing output directories in jobs launched by the streaming | ||
// scheduler, since we may need to write output to an existing directory during checkpoint | ||
// recovery; see SPARK-4835 for more details. | ||
PairRDDFunctions.disableOutputSpecValidation.withValue(true) { | ||
job.run() | ||
} | ||
eventLoop.post(JobCompleted(job)) | ||
} finally { | ||
ssc.sc.setLocalProperty(JobScheduler.BATCH_TIME_PROPERTY_KEY, null) | ||
ssc.sc.setLocalProperty(JobScheduler.OUTPUT_OP_ID_PROPERTY_KEY, null) | ||
} | ||
eventLoop.post(JobCompleted(job)) | ||
} | ||
} | ||
} | ||
|
||
private[streaming] object JobScheduler { | ||
val BATCH_TIME_PROPERTY_KEY = "spark.streaming.internal.batchTime" | ||
val OUTPUT_OP_ID_PROPERTY_KEY = "spark.streaming.internal.outputOpId" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you define what is
id
andoutputId
(especially that output id is unique within the jobset)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments on the
def outputOpId: Int
anddef id: String
.