[SQL] Fixed expression data type matching. #5675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug introduced by apache#5350
| @@ -279,7 +279,7 @@ abstract class CodeGenerator[InType <: AnyRef, OutType <: AnyRef] extends Loggin | |||
| org.apache.spark.sql.types.UTF8String(${eval.primitiveTerm}.toString) | |||
| """.children | |||
|
|
|||
| case EqualTo(e1: BinaryType, e2: BinaryType) => | |||
| case EqualTo(e1 @ BinaryType(), e2 @ BinaryType()) => | |||
There was a problem hiding this comment.
This is a bug introduced in #5350
|
Test build #30902 has finished for PR 5675 at commit
|
| /** Matches any expression that evaluates to this DataType */ | ||
| def unapply(a: Expression): Boolean = a match { | ||
| /** | ||
| * Enables matching against NumericType for expressions: |
There was a problem hiding this comment.
typo? Seems it should be DataType.
There was a problem hiding this comment.
ah yes - I will fix that.
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
May 14, 2015
Also took the chance to improve documentation for various types. Author: Reynold Xin <rxin@databricks.com> Closes apache#5675 from rxin/data-type-matching-expr and squashes the following commits: 0f31856 [Reynold Xin] One more function documentation. 27c1973 [Reynold Xin] Added more documentation. 336a36d [Reynold Xin] [SQL] Fixed expression data type matching.
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
Also took the chance to improve documentation for various types. Author: Reynold Xin <rxin@databricks.com> Closes apache#5675 from rxin/data-type-matching-expr and squashes the following commits: 0f31856 [Reynold Xin] One more function documentation. 27c1973 [Reynold Xin] Added more documentation. 336a36d [Reynold Xin] [SQL] Fixed expression data type matching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also took the chance to improve documentation for various types.