-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Streaming][Kafka] cleanup tests from SPARK-2808 #5921
Conversation
… for waitUntilLeaderOffset calls in tests
Can one of the admins verify this patch? |
This is ok to test |
Ok to test |
Merged build triggered. |
Merged build started. |
Test build #31904 has started for PR 5921 at commit |
Test build #31904 has finished for PR 5921 at commit
|
Merged build finished. Test FAILed. |
Test FAILed. |
Pretty sure this error [error] oro#oro;2.0.8!oro.jar origin location must be absolute: isn't related to the commit |
Merged build triggered. |
Merged build started. |
Test build #31926 has started for PR 5921 at commit |
Test build #31926 has finished for PR 5921 at commit
|
Merged build finished. Test PASSed. |
Test PASSed. |
@tdas just pinging on this to make sure it doesn't get lost in the shuffle, lmk if there's more explanation needed. |
I havent forgotten about this. I will pull it in. |
Another ping on this, even if it misses 1.4 Seeing waitUntilLeaderOffset all over the place in test code I'm working on right now made me sad :( |
Just to double check: Jenkins, retest this please |
Jenkins, retest this please |
Merged build triggered. |
Merged build started. |
Test build #34183 has started for PR 5921 at commit |
Test build #34183 has finished for PR 5921 at commit
|
Merged build finished. Test FAILed. |
The only thing I can think of mima complaining about is that this patch is removing a method... even though it's a method in a private class that is only used for testing. Don't know why it didn't complain the first time around. |
Merged build triggered. |
Merged build started. |
Test build #34186 has started for PR 5921 at commit |
Merged build triggered. |
Merged build started. |
Test build #34187 has started for PR 5921 at commit |
Test build #34186 has finished for PR 5921 at commit
|
Merged build finished. Test FAILed. |
Test build #34187 has finished for PR 5921 at commit
|
Merged build finished. Test PASSed. |
Looks like it's passing now but needs a rebase |
Merged build triggered. |
Merged build started. |
Test build #34278 has started for PR 5921 at commit |
Test build #34278 timed out for PR 5921 at commit |
Merged build finished. Test FAILed. |
I sort of doubt that wait timeout was related to the merge, the only conflict was the single line of MimaExcludes |
Jenkins, retest this please |
Merged build triggered. |
Merged build started. |
Test build #34330 has started for PR 5921 at commit |
Test build #34330 has finished for PR 5921 at commit
|
Merged build finished. Test PASSed. |
@tdas are you OK with this change? |
see if requiring producer acks eliminates the need for waitUntilLeaderOffset calls in tests Author: cody koeninger <cody@koeninger.org> Closes apache#5921 from koeninger/kafka-0.8.2-test-cleanup and squashes the following commits: 1e89dc8 [cody koeninger] Merge branch 'master' into kafka-0.8.2-test-cleanup 4662828 [cody koeninger] [Streaming][Kafka] filter mima issue for removal of method from private test class af1e083 [cody koeninger] Merge branch 'master' into kafka-0.8.2-test-cleanup 4298ac2 [cody koeninger] [Streaming][Kafka] update comment to trigger jenkins attempt 1274afb [cody koeninger] [Streaming][Kafka] see if requiring producer acks eliminates the need for waitUntilLeaderOffset calls in tests
see if requiring producer acks eliminates the need for waitUntilLeaderOffset calls in tests