Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streaming][Kafka] cleanup tests from SPARK-2808 #5921

Closed
wants to merge 5 commits into from

Conversation

koeninger
Copy link
Contributor

see if requiring producer acks eliminates the need for waitUntilLeaderOffset calls in tests

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@tdas
Copy link
Contributor

tdas commented May 5, 2015

This is ok to test

@tdas
Copy link
Contributor

tdas commented May 5, 2015

Ok to test

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 5, 2015

Test build #31904 has started for PR 5921 at commit 1274afb.

@SparkQA
Copy link

SparkQA commented May 5, 2015

Test build #31904 has finished for PR 5921 at commit 1274afb.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public class EnumUtil
    • class BinaryClassificationEvaluator(JavaEvaluator, HasLabelCol, HasRawPredictionCol):
    • class HasRawPredictionCol(Params):
    • class Evaluator(object):
    • class JavaEvaluator(Evaluator, JavaWrapper):

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31904/
Test FAILed.

@koeninger
Copy link
Contributor Author

Pretty sure this error

[error] oro#oro;2.0.8!oro.jar origin location must be absolute:

isn't related to the commit

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #31926 has started for PR 5921 at commit 4298ac2.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #31926 has finished for PR 5921 at commit 4298ac2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31926/
Test PASSed.

@koeninger
Copy link
Contributor Author

@tdas just pinging on this to make sure it doesn't get lost in the shuffle, lmk if there's more explanation needed.

@tdas
Copy link
Contributor

tdas commented May 18, 2015

I havent forgotten about this. I will pull it in.

@koeninger
Copy link
Contributor Author

Another ping on this, even if it misses 1.4

Seeing waitUntilLeaderOffset all over the place in test code I'm working on right now made me sad :(

@srowen
Copy link
Member

srowen commented Jun 4, 2015

Just to double check: Jenkins, retest this please

@srowen
Copy link
Member

srowen commented Jun 4, 2015

Jenkins, retest this please

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jun 4, 2015

Test build #34183 has started for PR 5921 at commit 4298ac2.

@SparkQA
Copy link

SparkQA commented Jun 4, 2015

Test build #34183 has finished for PR 5921 at commit 4298ac2.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@koeninger
Copy link
Contributor Author

The only thing I can think of mima complaining about is that this patch is removing a method... even though it's a method in a private class that is only used for testing. Don't know why it didn't complain the first time around.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jun 4, 2015

Test build #34186 has started for PR 5921 at commit af1e083.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jun 4, 2015

Test build #34187 has started for PR 5921 at commit 4662828.

@SparkQA
Copy link

SparkQA commented Jun 4, 2015

Test build #34186 has finished for PR 5921 at commit af1e083.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@SparkQA
Copy link

SparkQA commented Jun 4, 2015

Test build #34187 has finished for PR 5921 at commit 4662828.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@srowen
Copy link
Member

srowen commented Jun 5, 2015

Looks like it's passing now but needs a rebase

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jun 5, 2015

Test build #34278 has started for PR 5921 at commit 1e89dc8.

@SparkQA
Copy link

SparkQA commented Jun 5, 2015

Test build #34278 timed out for PR 5921 at commit 1e89dc8 after a configured wait of 175m.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@koeninger
Copy link
Contributor Author

I sort of doubt that wait timeout was related to the merge, the only conflict was the single line of MimaExcludes

@srowen
Copy link
Member

srowen commented Jun 5, 2015

Jenkins, retest this please

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jun 5, 2015

Test build #34330 has started for PR 5921 at commit 1e89dc8.

@SparkQA
Copy link

SparkQA commented Jun 6, 2015

Test build #34330 has finished for PR 5921 at commit 1e89dc8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@srowen
Copy link
Member

srowen commented Jun 6, 2015

@tdas are you OK with this change?

@asfgit asfgit closed this in b127ff8 Jun 8, 2015
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
see if requiring producer acks eliminates the need for waitUntilLeaderOffset calls in tests

Author: cody koeninger <cody@koeninger.org>

Closes apache#5921 from koeninger/kafka-0.8.2-test-cleanup and squashes the following commits:

1e89dc8 [cody koeninger] Merge branch 'master' into kafka-0.8.2-test-cleanup
4662828 [cody koeninger] [Streaming][Kafka] filter mima issue for removal of method from private test class
af1e083 [cody koeninger] Merge branch 'master' into kafka-0.8.2-test-cleanup
4298ac2 [cody koeninger] [Streaming][Kafka] update comment to trigger jenkins attempt
1274afb [cody koeninger] [Streaming][Kafka] see if requiring producer acks eliminates the need for waitUntilLeaderOffset calls in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants