Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] [Minor] make star and multialias extend NamedExpression #5928

Closed
wants to merge 1 commit into from

Conversation

scwf
Copy link
Contributor

@scwf scwf commented May 6, 2015

Star and MultiAlias just used in analyzer and them will be substituted after analyze, So just like Alias they do not need extend Attribute

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #31924 has started for PR 5928 at commit 73a0560.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #31924 has finished for PR 5928 at commit 73a0560.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait Star extends NamedExpression with trees.LeafNode[Expression]

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31924/
Test PASSed.

@scwf
Copy link
Contributor Author

scwf commented May 6, 2015

/cc @marmbrus

asfgit pushed a commit that referenced this pull request May 7, 2015
`Star` and `MultiAlias` just used in `analyzer` and them will be substituted after analyze,  So just like `Alias` they do not need extend `Attribute`

Author: scwf <wangfei1@huawei.com>

Closes #5928 from scwf/attribute and squashes the following commits:

73a0560 [scwf] star and multialias do not need extend attribute

(cherry picked from commit 97d1182)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@marmbrus
Copy link
Contributor

marmbrus commented May 7, 2015

Thanks merged to master and 1.4

@asfgit asfgit closed this in 97d1182 May 7, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
`Star` and `MultiAlias` just used in `analyzer` and them will be substituted after analyze,  So just like `Alias` they do not need extend `Attribute`

Author: scwf <wangfei1@huawei.com>

Closes apache#5928 from scwf/attribute and squashes the following commits:

73a0560 [scwf] star and multialias do not need extend attribute
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
`Star` and `MultiAlias` just used in `analyzer` and them will be substituted after analyze,  So just like `Alias` they do not need extend `Attribute`

Author: scwf <wangfei1@huawei.com>

Closes apache#5928 from scwf/attribute and squashes the following commits:

73a0560 [scwf] star and multialias do not need extend attribute
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
`Star` and `MultiAlias` just used in `analyzer` and them will be substituted after analyze,  So just like `Alias` they do not need extend `Attribute`

Author: scwf <wangfei1@huawei.com>

Closes apache#5928 from scwf/attribute and squashes the following commits:

73a0560 [scwf] star and multialias do not need extend attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants