Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-5913] [MLLIB] Python API for ChiSqSelector #5939

Closed
wants to merge 1 commit into from

Conversation

yanboliang
Copy link
Contributor

Add a Python API for mllib.feature.ChiSqSelector
https://issues.apache.org/jira/browse/SPARK-5913

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #31973 has started for PR 5939 at commit cdaac99.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #31973 has finished for PR 5939 at commit cdaac99.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ChiSqSelectorModel(JavaVectorTransformer):
    • class ChiSqSelector(object):

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31973/
Test PASSed.

@yanboliang
Copy link
Contributor Author

@mengxr , @jkbradley

@jkbradley
Copy link
Member

I'll take a look now

@jkbradley
Copy link
Member

I don't see any issues except for documentation. Could you please make the Python docs match the Scala ones? (We've been lazy about keeping them in synch, but I want to push for Python doc parity.) Thanks!

As a follow up PR, we can finally add a Python code example to the programming guide!

@jkbradley
Copy link
Member

Oh, also, can you please update the PR description with more details? Feel free to copy from the JIRA.

@yanboliang
Copy link
Contributor Author

@jkbradley , I think the Python docs for ChiSqSelector and ChiSqSelectorModel have reached parity with Scala ones. Please correct me is I misunderstand.
Yes, I will add a Python code example to the programming guide in a follow up PR. We also need to check other API and add corresponding Python code examples.

@jkbradley
Copy link
Member

@yanboliang Sorry, I just assumed the Scala doc had more content. I'll make that a to-do for later. In this case, LGTM!

For the API check, we're gradually putting together a list of the many items under this umbrella: [https://issues.apache.org/jira/browse/SPARK-7443]

Merging into master and branch-1.4

@jkbradley
Copy link
Member

Hm, the merge script complains that this is not mergeable currently. I'll re-run the tests

@SparkQA
Copy link

SparkQA commented May 8, 2015

Test build #788 has started for PR 5939 at commit cdaac99.

@SparkQA
Copy link

SparkQA commented May 8, 2015

Test build #788 has finished for PR 5939 at commit cdaac99.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ChiSqSelectorModel(JavaVectorTransformer):
    • class ChiSqSelector(object):

@jkbradley
Copy link
Member

Weird, I'll investigate

asfgit pushed a commit that referenced this pull request May 8, 2015
Add a Python API for mllib.feature.ChiSqSelector
https://issues.apache.org/jira/browse/SPARK-5913

Author: Yanbo Liang <ybliang8@gmail.com>

Closes #5939 from yanboliang/spark-5913 and squashes the following commits:

cdaac99 [Yanbo Liang] Python API for ChiSqSelector

(cherry picked from commit 35c9599)
Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
@asfgit asfgit closed this in 35c9599 May 8, 2015
@jkbradley
Copy link
Member

It worked this time. Thanks!

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
Add a Python API for mllib.feature.ChiSqSelector
https://issues.apache.org/jira/browse/SPARK-5913

Author: Yanbo Liang <ybliang8@gmail.com>

Closes apache#5939 from yanboliang/spark-5913 and squashes the following commits:

cdaac99 [Yanbo Liang] Python API for ChiSqSelector
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
Add a Python API for mllib.feature.ChiSqSelector
https://issues.apache.org/jira/browse/SPARK-5913

Author: Yanbo Liang <ybliang8@gmail.com>

Closes apache#5939 from yanboliang/spark-5913 and squashes the following commits:

cdaac99 [Yanbo Liang] Python API for ChiSqSelector
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
Add a Python API for mllib.feature.ChiSqSelector
https://issues.apache.org/jira/browse/SPARK-5913

Author: Yanbo Liang <ybliang8@gmail.com>

Closes apache#5939 from yanboliang/spark-5913 and squashes the following commits:

cdaac99 [Yanbo Liang] Python API for ChiSqSelector
@yanboliang yanboliang deleted the spark-5913 branch June 26, 2015 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants