Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARK-1759 #693

Closed
wants to merge 1 commit into from
Closed

SPARK-1759 #693

wants to merge 1 commit into from

Conversation

pjopensource
Copy link

No description provided.

@pjopensource
Copy link
Author

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented May 8, 2014

I don't think it's intended that you use sbt/sbt for other projects. It's specific to Spark. Right? You can use the regular sbt app of course.

@pjopensource
Copy link
Author

yes, it's specific to spark.

2014-05-08 20:52 GMT+08:00 Sean Owen notifications@github.com:

I don't think it's intended that you use sbt/sbt for other projects. It's
specific to Spark. Right? You can use the regular sbt app of course.


Reply to this email directly or view it on GitHubhttps://github.com//pull/693#issuecomment-42545954
.

@srowen
Copy link
Member

srowen commented May 8, 2014

Yes, so if you are making your own separate project, even if it's Spark-based, you should be using the regular SBT and its sbt binary in your build, not this script that is for building Spark itself, IIUC. This would now require now setting SPARK_HOME, for example, when it seems a little funny to have to do so from the top-level of the project itself.

@pjopensource
Copy link
Author

OK,I see. The sbt script in spark is just for building the Spark itself,not
for other project.Thanks very much.
I was confused by the quickstart doc
http://spark.apache.org/docs/latest/quick-start.html,it use the sbt/sbt to
build the simpleApp project. maybe we should revise the doc.

2014-05-08 22:14 GMT+08:00 Sean Owen notifications@github.com:

Yes, so if you are making your own separate project, even if it's
Spark-based, you should be using the regular SBT and its sbt binary in
your build, not this script that is for building Spark itself, IIUC. This
would now require now setting SPARK_HOME, for example, when it seems a
little funny to have to do so from the top-level of the project itself.


Reply to this email directly or view it on GitHubhttps://github.com//pull/693#issuecomment-42554599
.

@srowen
Copy link
Member

srowen commented May 9, 2014

Yes, maybe someone can double-check me, but I imagine it is meant to show using just sbt. There is no sbt/ directory created in this sample to begin with, and the script doesn't seem set up to be used elsewhere for the reason you give. Maybe change your PR to instead suggest the doc change?

@rxin
Copy link
Contributor

rxin commented May 13, 2014

Do you mind closing this if it is no longer necessary? Thanks.

@asfgit asfgit closed this in 2c35666 Jul 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants