[SPARK-8573] [SPARK-8568] [SQL] [PYSPARK] raise Exception if column is used in booelan expression #6961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rxin |
| @@ -396,6 +396,11 @@ def over(self, window): | |||
| jc = self._jc.over(window._jspec) | |||
| return Column(jc) | |||
|
|
|||
| def __nonzero__(self): | |||
| raise ValueError("Can't convert column into bool: please use '&' for 'and', '|' for 'or', " | |||
There was a problem hiding this comment.
Can we mention not as well?
And "Can't" -> "Cannot"
|
lgtm otherwise |
|
@rxin updated. |
| @@ -396,6 +396,11 @@ def over(self, window): | |||
| jc = self._jc.over(window._jspec) | |||
| return Column(jc) | |||
|
|
|||
| def __nonzero__(self): | |||
| raise ValueError("Cannot convert column into bool: please use '&' for 'and', '|' for 'or', " | |||
| "'~'for 'not', when using Column in a boolean expression.") | |||
There was a problem hiding this comment.
missed a space after ~
actually let's do this
Cannot convert column into bool: please use '&' for 'and', '|' for 'or', and '~' for 'not' when building DataFrame boolean expressions.
davies
changed the title
|
Test build #35590 has finished for PR 6961 at commit
|
|
Test build #954 has finished for PR 6961 at commit
|
|
Test build #35592 has finished for PR 6961 at commit
|
added 2 commits
June 23, 2015 14:39
|
Test build #35597 has finished for PR 6961 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jun 23, 2015
…s used in booelan expression It's a common mistake that user will put Column in a boolean expression (together with `and` , `or`), which does not work as expected, we should raise a exception in that case, and suggest user to use `&`, `|` instead. Author: Davies Liu <davies@databricks.com> Closes #6961 from davies/column_bool and squashes the following commits: 9f19beb [Davies Liu] update message af74bd6 [Davies Liu] fix tests 07dff84 [Davies Liu] address comments, fix tests f70c08e [Davies Liu] raise Exception if column is used in booelan expression (cherry picked from commit 7fb5ae5) Signed-off-by: Davies Liu <davies@databricks.com>
|
Test build #35604 has finished for PR 6961 at commit
|
|
Merged build finished. Test FAILed. |
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 25, 2015
…s used in booelan expression It's a common mistake that user will put Column in a boolean expression (together with `and` , `or`), which does not work as expected, we should raise a exception in that case, and suggest user to use `&`, `|` instead. Author: Davies Liu <davies@databricks.com> Closes apache#6961 from davies/column_bool and squashes the following commits: 9f19beb [Davies Liu] update message af74bd6 [Davies Liu] fix tests 07dff84 [Davies Liu] address comments, fix tests f70c08e [Davies Liu] raise Exception if column is used in booelan expression (cherry picked from commit 7fb5ae5) Signed-off-by: Davies Liu <davies@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a common mistake that user will put Column in a boolean expression (together with
and,or), which does not work as expected, we should raise a exception in that case, and suggest user to use&,|instead.