Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-11233][SQL] register cosh in function registry #9199

Closed

Conversation

shagunsodhani
Copy link
Contributor

No description provided.

@rxin
Copy link
Contributor

rxin commented Oct 21, 2015

Jenkins, test this please.

@rxin
Copy link
Contributor

rxin commented Oct 21, 2015

@shagunsodhani can you change the title to "[SPARK-11233][SQL] register cosh in function registry".

@shagunsodhani shagunsodhani changed the title fixes SPARK-11233: registered cosh is in function registry [SPARK-11233][SQL] register cosh in function registry Oct 21, 2015
@shagunsodhani
Copy link
Contributor Author

@rxin 👍

@srutis
Copy link

srutis commented Oct 21, 2015

Sruti S sruti.shivakumar@gmail.com
9:29 AM (4 hours ago)

to Shagun

A quick look through the source of FunctionRegistry.scala seems to indicate that the function is missing from a lookup table, so it looks like a simple fix to add the entry will resolve the issue.

object FunctionRegistry {

type FunctionBuilder = Seq[Expression] => Expression

val expressions: Map[String, (ExpressionInfo, FunctionBuilder)] = Map(
...
...

// math functions
expressionAcos,
expressionAsin,
expressionAtan,
expressionAtan2,
expressionBin,
expressionCbrt,
expressionCeil,
expressionCeil,
expressionCos,
/* Add here ---> */ expressionCosh,

@JoshRosen
Copy link
Contributor

Jenkins, this is ok to test.

@SparkQA
Copy link

SparkQA commented Oct 21, 2015

Test build #44081 has finished for PR 9199 at commit d89931a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Oct 21, 2015

Thanks - I've merged this.

asfgit pushed a commit that referenced this pull request Oct 21, 2015
Author: Shagun Sodhani <sshagunsodhani@gmail.com>

Closes #9199 from shagunsodhani/proposed-fix-#11233.

(cherry picked from commit 19ad186)
Signed-off-by: Reynold Xin <rxin@databricks.com>
@asfgit asfgit closed this in 19ad186 Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants