[SPARK-5966][WIP]<Spark-submit deploy-mode cluster is not compatible with master local> #9220
Conversation
kevinyu98
changed the title
|
LGTM |
|
Test build #1938 has finished for PR 9220 at commit
|
| // SPARK-5966, check deployMode CLUSTER and master local | ||
| if (clusterManager == LOCAL && deployMode == CLUSTER) { | ||
| printErrorAndExit("Cluster deploy mode is not compatible with master \"local\"") | ||
| } |
There was a problem hiding this comment.
there's a place down there (L321) where we do checks like this. Please move it down there to be more consistent
There was a problem hiding this comment.
Hello Andrew: Thanks for pointing this out, I have made the code changes, run the test , and submit the pull request, can you help review?
Kevin
| @@ -0,0 +1 @@ | |||
| 1+1; | |||
There was a problem hiding this comment.
Why this change? Unintentional?
There was a problem hiding this comment.
Hello Josh: Sorry, it is unintentional. I have deleted the new file and push again.
|
retest this please |
|
LGTM, will merge once tests pass. |
| @@ -266,6 +266,7 @@ object SparkSubmit { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
nit: I'm going to nix this blank line when I merge (no action required on your part)
|
Test build #44252 has finished for PR 9220 at commit
|
|
Merged to master/1.5 (after removing that blank line) |
… master local>