Update run-example #988
Closed
Update run-example #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old code can only be ran under spark_home and use "bin/run-example". Error "./run-example: line 55: ./bin/spark-submit: No such file or directory" appears when running in other place. So change this
|
Can one of the admins verify this patch? |
|
Maybe it's better to change it to "$FWDIR"/bin/spark-submit and commit it into apache:master |
|
Thanks for finding this fix! Since this is a user-facing bug, do you mind creating a JIRA? Also it is slightly better if you make the PR into the master branch. And also yes, adding quotes would better too. |
|
OK, SPARK-2057 is opened for tracing this issue. |
|
Thanks for creating the JIRA! Would you mind (a) adding the quotes around the dir and (b) opening this against the master branch? Then we can merge it and back-port it into 1.0.1 |
| @@ -51,7 +51,7 @@ if [[ ! $EXAMPLE_CLASS == org.apache.spark.examples* ]]; then | |||
| EXAMPLE_CLASS="org.apache.spark.examples.$EXAMPLE_CLASS" | |||
| fi | |||
|
|
|||
| ./bin/spark-submit \ | |||
| $FWDIR/bin/spark-submit \ | |||
There was a problem hiding this comment.
Would be better to do:
"$FWDIR"/bin/spark-submit
|
i agree that and patch #1011 is opened against the master branch. you can merge it and back-port it into 1.0.1 |
Closed
asfgit
pushed a commit
that referenced
this pull request
Jun 8, 2014
Old code can only be ran under spark_home and use "bin/run-example". Error "./run-example: line 55: ./bin/spark-submit: No such file or directory" appears when running in other place. So change this Author: maji2014 <maji3@asiainfo-linkage.com> Closes #1011 from maji2014/master and squashes the following commits: 2cc1af6 [maji2014] Update run-example Closes #988. (cherry picked from commit e9261d0) Signed-off-by: Patrick Wendell <pwendell@gmail.com>
pdeyhim
pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
Old code can only be ran under spark_home and use "bin/run-example". Error "./run-example: line 55: ./bin/spark-submit: No such file or directory" appears when running in other place. So change this Author: maji2014 <maji3@asiainfo-linkage.com> Closes apache#1011 from maji2014/master and squashes the following commits: 2cc1af6 [maji2014] Update run-example Closes apache#988.
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
Old code can only be ran under spark_home and use "bin/run-example". Error "./run-example: line 55: ./bin/spark-submit: No such file or directory" appears when running in other place. So change this Author: maji2014 <maji3@asiainfo-linkage.com> Closes apache#1011 from maji2014/master and squashes the following commits: 2cc1af6 [maji2014] Update run-example Closes apache#988.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code can only be ran under spark_home and use "bin/run-example".
Error "./run-example: line 55: ./bin/spark-submit: No such file or directory" appears when running in other place. So change this