STORM-3693: Pending tuples expired only once per tick. #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathanmarz I am wondering if I can do something more to garner some attention to this PR. The fix seems to address a fundamental bug related to tuple expiry. |
|
@reiabreu wdyt about this? |
|
@rzo1 I'm not familiar with this code. Let me have a look and report back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
(To ensure spout pending tuples are expired only once per tick. Otherwise, tuples get expired prematurely when one spout executor has multiple tasks.)
How was the change tested
(1. mvn clean install -P '!examples,!externals' 2. Used a dummy topology to test the correct behavior.)