chore: tests for #24249

apache · May 30, 2023 · 0e0e7da · 0e0e7da
1 parent 7e70f19
commit 0e0e7da
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/superset-frontend/src/dashboard/util/permissionUtils.test.ts b/superset-frontend/src/dashboard/util/permissionUtils.test.ts
@@ -61,7 +61,6 @@ const owner: Owner = {
   first_name: 'Test',
   id: ownerUser.userId!,
   last_name: 'User',
-  username: ownerUser.username,
 };
 
 const sqlLabUser: UserWithPermissionsAndRoles = {

diff --git a/superset-frontend/src/dashboard/util/permissionUtils.ts b/superset-frontend/src/dashboard/util/permissionUtils.ts
@@ -50,7 +50,7 @@ export const canUserEditDashboard = (
 ) =>
   isUserWithPermissionsAndRoles(user) &&
   (isUserAdmin(user) || isUserDashboardOwner(dashboard, user)) &&
-  findPermission('can_write', 'Dashboard', user.roles);
+  findPermission('can_write', 'Dashboard', user?.roles);
 
 export function canUserAccessSqlLab(
   user?: UserWithPermissionsAndRoles | UndefinedUser,

diff --git a/superset-frontend/src/types/Owner.ts b/superset-frontend/src/types/Owner.ts
@@ -25,6 +25,4 @@ export default interface Owner {
   first_name: string;
   id: number;
   last_name: string;
-  username: string;
-  email?: string;
 }