Skip to content

Commit

Permalink
Do not fail is the filter cannot be parsed. (#2105)
Browse files Browse the repository at this point in the history
  • Loading branch information
bkyryliuk authored Feb 3, 2017
1 parent a6e0f1b commit 0f7189b
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion superset/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -1376,7 +1376,11 @@ def visit_column(element, compiler, **kw):
values = [types.strip() for types in splitted]
# attempt to get the values type if they are not in quotes
if not col_obj.is_string:
values = [ast.literal_eval(v) for v in values]
try:
values = [ast.literal_eval(v) for v in values]
except Exception as e:
logging.info(utils.error_msg_from_exception(e))
values = [v.replace("'", '').strip() for v in values]
else:
values = [v.replace("'", '').strip() for v in values]
cond = col_obj.sqla_col.in_(values)
Expand Down

0 comments on commit 0f7189b

Please sign in to comment.