Add null checks

apache · Sep 18, 2020 · 20259fe · 20259fe
1 parent 7a50789
commit 20259fe
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/superset-frontend/src/SqlLab/components/LimitControl.tsx b/superset-frontend/src/SqlLab/components/LimitControl.tsx
@@ -115,7 +115,7 @@ export default class LimitControl extends React.PureComponent<
                 event: React.FormEvent<FormControl & FormControlProps>,
               ) =>
                 this.setState({
-                  textValue: (event.currentTarget.value as string) ?? '',
+                  textValue: (event.currentTarget?.value as string) ?? '',
                 })
               }
             />

diff --git a/superset-frontend/src/components/DeleteModal.tsx b/superset-frontend/src/components/DeleteModal.tsx
@@ -73,7 +73,7 @@ export default function DeleteModal({
           onChange={(
             event: React.FormEvent<FormControl & FormControlProps>,
           ) => {
-            const targetValue = (event.currentTarget.value as string) ?? '';
+            const targetValue = (event.currentTarget?.value as string) ?? '';
             setDisableChange(targetValue.toUpperCase() !== 'DELETE');
           }}
         />

diff --git a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx
@@ -117,7 +117,7 @@ const ChangeDatasourceModal: FunctionComponent<ChangeDatasourceModalProps> = ({
   const changeSearch = (
     event: React.FormEvent<FormControl & FormControlProps>,
   ) => {
-    setFilter((event.currentTarget.value as string) ?? '');
+    setFilter((event.currentTarget?.value as string) ?? '');
   };
 
   return (

diff --git a/superset-frontend/src/explore/components/PropertiesModal.tsx b/superset-frontend/src/explore/components/PropertiesModal.tsx
@@ -177,7 +177,7 @@ function PropertiesModal({ slice, onHide, onSave }: InternalProps) {
                 value={name}
                 onChange={(
                   event: React.FormEvent<FormControl & FormControlProps>,
-                ) => setName((event.currentTarget.value as string) ?? '')}
+                ) => setName((event.currentTarget?.value as string) ?? '')}
               />
             </FormGroup>
             <FormGroup>
@@ -191,7 +191,7 @@ function PropertiesModal({ slice, onHide, onSave }: InternalProps) {
                 onChange={(
                   event: React.FormEvent<FormControl & FormControlProps>,
                 ) =>
-                  setDescription((event.currentTarget.value as string) ?? '')
+                  setDescription((event.currentTarget?.value as string) ?? '')
                 }
                 style={{ maxWidth: '100%' }}
               />
@@ -215,7 +215,7 @@ function PropertiesModal({ slice, onHide, onSave }: InternalProps) {
                   event: React.FormEvent<FormControl & FormControlProps>,
                 ) => {
                   const targetValue =
-                    (event.currentTarget.value as string) ?? '';
+                    (event.currentTarget?.value as string) ?? '';
                   setCacheTimeout(targetValue.replace(/[^0-9]/, ''));
                 }}
               />