Skip to content

Commit

Permalink
Enabled pylint rules in db_engines module: (#11016)
Browse files Browse the repository at this point in the history
- `unused_import` and `import_error` - not promting anymore
- changed unused param to private and removed `unused_argument`
  • Loading branch information
kkucharc authored Sep 23, 2020
1 parent a26f29e commit 26fcc08
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions superset/db_engines/hive.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@
from typing import Optional, TYPE_CHECKING

if TYPE_CHECKING:
from pyhive.hive import Cursor # pylint: disable=unused-import
from TCLIService.ttypes import TFetchOrientation # pylint: disable=unused-import
from pyhive.hive import Cursor
from TCLIService.ttypes import TFetchOrientation

# pylint: disable=protected-access
# TODO: contribute back to pyhive.
def fetch_logs(
self: "Cursor",
max_rows: int = 1024, # pylint: disable=unused-argument
_max_rows: int = 1024,
orientation: Optional["TFetchOrientation"] = None,
) -> str: # pylint: disable=unused-argument
) -> str:
"""Mocked. Retrieve the logs produced by the execution of the query.
Can be called multiple times to fetch the logs produced after
the previous call.
Expand All @@ -37,7 +37,7 @@ def fetch_logs(
"""
from pyhive import hive
from TCLIService import ttypes
from thrift import Thrift # pylint: disable=import-error
from thrift import Thrift

orientation = orientation or ttypes.TFetchOrientation.FETCH_NEXT
try:
Expand Down

0 comments on commit 26fcc08

Please sign in to comment.