Fix test

apache · Mar 31, 2022 · 28d0c0f · 28d0c0f
1 parent 4cf45b1
commit 28d0c0f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/superset-frontend/cypress-base/cypress/integration/explore/link.test.ts b/superset-frontend/cypress-base/cypress/integration/explore/link.test.ts
@@ -54,7 +54,8 @@ describe('Test explore links', () => {
 
     cy.get('[aria-label="Menu actions trigger"]').click();
     cy.get('div[title="Share"]').trigger('mouseover');
-    cy.get('[data-test="ExploreAdditionalActionsMenu_share"]').within(() => {
+    // need to use [id= syntax, otherwise error gets triggered because of special character in id
+    cy.get('[id="share_submenu$Menu"]').within(() => {
       cy.contains('Embed code').parent().click();
     });
     cy.get('#embed-code-popover').within(() => {

diff --git a/superset-frontend/src/explore/components/ExploreAdditionalActionsMenu/index.jsx b/superset-frontend/src/explore/components/ExploreAdditionalActionsMenu/index.jsx
@@ -344,11 +344,7 @@ const ExploreAdditionalActionsMenu = ({
                 {t('Download as image')}
               </Menu.Item>
             </Menu.SubMenu>
-            <Menu.SubMenu
-              title={t('Share')}
-              key={MENU_KEYS.SHARE_SUBMENU}
-              data-test="ExploreAdditionalActionsMenu_share"
-            >
+            <Menu.SubMenu title={t('Share')} key={MENU_KEYS.SHARE_SUBMENU}>
               <Menu.Item key={MENU_KEYS.COPY_PERMALINK}>
                 {t('Copy permalink to clipboard')}
               </Menu.Item>