Skip to content

Commit

Permalink
druid connector: avoid using 'dimensions' for scan queries
Browse files Browse the repository at this point in the history
After the following PyDruid change (contained in version 0.5.2)
the Superset Histogram charts rendered with Druid data are
broken:

druid-io/pydruid@0a59a70

Bump the pydruid requirements accordingly in setup.py

Issue: #7368
  • Loading branch information
elukey committed May 8, 2019
1 parent 4fe152d commit 3f1f4ad
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def get_git_sha():
'parsedatetime',
'pathlib2',
'polyline',
'pydruid>=0.4.3',
'pydruid>=0.5.2',
'python-dateutil',
'python-geohash',
'pyyaml>=3.13',
Expand Down
3 changes: 2 additions & 1 deletion superset/connectors/druid/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -1118,7 +1118,8 @@ def run_query( # noqa / druid
columns.append('__time')
del qry['post_aggregations']
del qry['aggregations']
qry['dimensions'] = columns
del qry['dimensions']
qry['columns'] = columns
qry['metrics'] = []
qry['granularity'] = 'all'
qry['limit'] = row_limit
Expand Down

0 comments on commit 3f1f4ad

Please sign in to comment.