feat: Adds a separator to Select All option

apache · Jan 19, 2023 · 5012b5e · 5012b5e
1 parent 577ac81
commit 5012b5e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/superset-frontend/.storybook/preview.jsx b/superset-frontend/.storybook/preview.jsx
@@ -87,5 +87,5 @@ addParameters({
       ],
     },
   },
-  controls: { expanded: true },
+  controls: { expanded: true, sort: 'alpha' },
 });
diff --git a/superset-frontend/src/components/Select/Select.tsx b/superset-frontend/src/components/Select/Select.tsx
@@ -467,6 +467,7 @@ const Select = forwardRef(
           {selectAllEnabled && (
             <Option
               id="select-all"
+              className="select-all"
               key={SELECT_ALL_VALUE}
               value={SELECT_ALL_VALUE}
             >

diff --git a/superset-frontend/src/components/Select/styles.tsx b/superset-frontend/src/components/Select/styles.tsx
@@ -52,7 +52,9 @@ export const StyledSelect = styled(AntdSelect, {
     .ant-select-arrow .anticon:not(.ant-select-suffix) {
       pointer-events: none;
     }
-
+    .select-all {
+      border-bottom: 1px solid ${theme.colors.grayscale.light3};
+    }
     ${
       oneLine &&
       `
-Original file line number
+Diff line change
@@ Expand Up / @@ -87,5 +87,5 @@ addParameters({ @@
           ],
         },
       },
-      controls: { expanded: true },
+      controls: { expanded: true, sort: 'alpha' },
     });